Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1397673002: port ARGB to 565 dithering SSE2 code to GCC. (Closed)

Created:
5 years, 2 months ago by fbarchard1
Modified:
5 years, 2 months ago
Reviewers:
harryjin
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

port ARGB to 565 dithering SSE2 code to GCC. Previously the assembly code was only available to Windows. This CL ports the SSE2 code to GCC syntax. When running a profiler on all the unittests, this function was the slowest of all functions that still ran in C code. 3.71% libyuv_unittest libyuv_unittest [.] ARGBToRGB565DitherRow_C Was ARGBToRGB565Dither_Opt (2894 ms) Now ARGBToRGB565Dither_Opt (432 ms) TBR=harryjin@google.com BUG=libyuv:492 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/cc89e3a77be30a27f7c56ee32860e5bbc9a00cc2

Patch Set 1 #

Patch Set 2 : remove comment about 8 pixels which is wrong #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -39 lines) Patch
M include/libyuv/row.h View 15 chunks +30 lines, -37 lines 0 comments Download
M source/row_gcc.cc View 1 1 chunk +46 lines, -0 lines 0 comments Download
M source/row_win.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fbarchard1
5 years, 2 months ago (2015-10-08 01:18:39 UTC) #1
fbarchard1
5 years, 2 months ago (2015-10-08 01:24:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cc89e3a77be30a27f7c56ee32860e5bbc9a00cc2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698