bluetooth_private -> IDL

bluetooth_private -> IDL

This CL converts bluetoothPrivate to use an IDL file instead of a JSON file to make future changes a bit easier.

It also adds externs files for bluetooth_private.js and bluetooth.js (which bluetooth_private.js depends on).

BUG=543294
Committed: https://crrev.com/dabca319609adddde1cba09ae28e03047af885b9
Cr-Commit-Position: refs/heads/master@{#355454}

[stevenjb, 2015-10-14 21:30:04]

stevenjb@chromium.org changed reviewers:
+ armansito@chromium.org, rdevlin.cronin@chromium.org

[stevenjb, 2015-10-14 23:41:30]

stevenjb@chromium.org changed reviewers:
+ keybuk@chromium.org

[Devlin, 2015-10-15 06:26:42]

lgtm with nits

https://codereview.chromium.org/1397653007/diff/20001/extensions/common/api/b...
File extensions/common/api/bluetooth.idl (right):

https://codereview.chromium.org/1397653007/diff/20001/extensions/common/api/b...
extensions/common/api/bluetooth.idl:39: // dictionary is also defined in
bluetooth_private.idl
Is it?  It shouldn't be.  Cross-references should work.  And, looking at the
idl, I don't see the duplicate definition.  Out-of-date comment?

https://codereview.chromium.org/1397653007/diff/20001/extensions/common/api/b...
File extensions/common/api/bluetooth_private.idl (right):

https://codereview.chromium.org/1397653007/diff/20001/extensions/common/api/b...
extensions/common/api/bluetooth_private.idl:1: // Copyright (c) 2015 The
Chromium Authors. All rights reserved.
nit: no (c)

https://codereview.chromium.org/1397653007/diff/20001/extensions/common/api/b...
extensions/common/api/bluetooth_private.idl:1: // Copyright (c) 2015 The
Chromium Authors. All rights reserved.
When I patched this in by hand, I saw a few trailing whitespace errors.  Can you
double-check that none are present in this patch?  (Rietveld makes it very
difficult to see, but it appears there may be some indentations on blank line
17, etc.)

https://codereview.chromium.org/1397653007/diff/20001/third_party/closure_com...
File third_party/closure_compiler/externs/bluetooth.js (right):

https://codereview.chromium.org/1397653007/diff/20001/third_party/closure_com...
third_party/closure_compiler/externs/bluetooth.js:155: 
nit: no newlines here (we should update the script to not have them, at some
point).

https://codereview.chromium.org/1397653007/diff/20001/third_party/closure_com...
File third_party/closure_compiler/externs/bluetooth_private.js (right):

https://codereview.chromium.org/1397653007/diff/20001/third_party/closure_com...
third_party/closure_compiler/externs/bluetooth_private.js:13: //
s/chrome.bluetoothPrivate.bluetooth.device/chrome.bluetooth.device/
Oh, yuck.  Can you file a bug for the generator to be updated to handle this
case?

https://codereview.chromium.org/1397653007/diff/20001/third_party/closure_com...
third_party/closure_compiler/externs/bluetooth_private.js:146: 
nit: ditto

[stevenjb, 2015-10-15 20:48:05]

stevenjb@chromium.org changed reviewers:
+ dbeam@chromium.org

[stevenjb, 2015-10-15 20:48:06]

+dbeam@ for third_party/closure_compiler/externs/ OWNER

https://codereview.chromium.org/1397653007/diff/20001/extensions/common/api/b...
File extensions/common/api/bluetooth.idl (right):

https://codereview.chromium.org/1397653007/diff/20001/extensions/common/api/b...
extensions/common/api/bluetooth.idl:39: // dictionary is also defined in
bluetooth_private.idl
On 2015/10/15 06:26:42, Devlin wrote:
> Is it?  It shouldn't be.  Cross-references should work.  And, looking at the
> idl, I don't see the duplicate definition.  Out-of-date comment?

WHoops, forgot to change the subject once I got the cross reference working
correctly. (Had to hand tweek the export JS, but I don't see us needing to do
that enough to justify fixing the exporter quite yet).

https://codereview.chromium.org/1397653007/diff/20001/extensions/common/api/b...
File extensions/common/api/bluetooth_private.idl (right):

https://codereview.chromium.org/1397653007/diff/20001/extensions/common/api/b...
extensions/common/api/bluetooth_private.idl:1: // Copyright (c) 2015 The
Chromium Authors. All rights reserved.
On 2015/10/15 06:26:42, Devlin wrote:
> nit: no (c)

Done.

https://codereview.chromium.org/1397653007/diff/20001/extensions/common/api/b...
extensions/common/api/bluetooth_private.idl:1: // Copyright (c) 2015 The
Chromium Authors. All rights reserved.
On 2015/10/15 06:26:42, Devlin wrote:
> When I patched this in by hand, I saw a few trailing whitespace errors.  Can
you
> double-check that none are present in this patch?  (Rietveld makes it very
> difficult to see, but it appears there may be some indentations on blank line
> 17, etc.)

Done.

https://codereview.chromium.org/1397653007/diff/20001/third_party/closure_com...
File third_party/closure_compiler/externs/bluetooth.js (right):

https://codereview.chromium.org/1397653007/diff/20001/third_party/closure_com...
third_party/closure_compiler/externs/bluetooth.js:155: 
On 2015/10/15 06:26:42, Devlin wrote:
> nit: no newlines here (we should update the script to not have them, at some
> point).

Acknowledged.

https://codereview.chromium.org/1397653007/diff/20001/third_party/closure_com...
File third_party/closure_compiler/externs/bluetooth_private.js (right):

https://codereview.chromium.org/1397653007/diff/20001/third_party/closure_com...
third_party/closure_compiler/externs/bluetooth_private.js:13: //
s/chrome.bluetoothPrivate.bluetooth.device/chrome.bluetooth.device/
On 2015/10/15 06:26:42, Devlin wrote:
> Oh, yuck.  Can you file a bug for the generator to be updated to handle this
> case?

Done. crbug.com/543822

[Dan Beam, 2015-10-16 07:27:34]

lgtm

[armansito, 2015-10-21 23:10:05]

lgtm

[stevenjb, 2015-10-21 23:22:46]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2015-10-21 23:22:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org, dbeam@chromium.org, armansito@chromium.org
Link to the patchset: https://codereview.chromium.org/1397653007/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2015-10-21 23:24:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397653007/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397653007/120001

[commit-bot: I haz the power, 2015-10-22 00:32:18]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-10-22 00:33:18]

Patchset 7 (id:??) landed as
https://crrev.com/dabca319609adddde1cba09ae28e03047af885b9
Cr-Commit-Position: refs/heads/master@{#355454}