Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Unified Diff: chrome/browser/ui/views/find_bar_view.h

Issue 13976011: Revert FindBarView::SearchTextfieldView deletion. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/find_bar_view.cc » ('j') | chrome/browser/ui/views/find_bar_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/find_bar_view.h
diff --git a/chrome/browser/ui/views/find_bar_view.h b/chrome/browser/ui/views/find_bar_view.h
index dd5e5d6dedbec385b97acfe312a799139608134b..7f3e89928ab1b2e520e02c97ac67bd28d2954a6f 100644
--- a/chrome/browser/ui/views/find_bar_view.h
+++ b/chrome/browser/ui/views/find_bar_view.h
@@ -110,12 +110,25 @@ class FindBarView : public DropdownBarView,
DISALLOW_COPY_AND_ASSIGN(FocusForwarderView);
};
+ // A wrapper of views::TextField that allows us to select all text when we
+ // get focus. Represents the text field where the user enters a search term.
+ class SearchTextfieldView : public views::Textfield {
+ public:
+ SearchTextfieldView();
+ virtual ~SearchTextfieldView();
+
+ virtual void RequestFocus() OVERRIDE;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(SearchTextfieldView);
+ };
+
// Returns the OS-specific view for the find bar that acts as an intermediary
// between us and the WebContentsView.
FindBarHost* find_bar_host() const;
// The controls in the window.
- views::Textfield* find_text_;
+ SearchTextfieldView* find_text_;
views::Label* match_count_text_;
FocusForwarderView* focus_forwarder_view_;
views::ImageButton* find_previous_button_;
« no previous file with comments | « no previous file | chrome/browser/ui/views/find_bar_view.cc » ('j') | chrome/browser/ui/views/find_bar_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698