Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 13976007: Land Recent QUIC Changes (Closed)

Created:
7 years, 8 months ago by ramant (doing other things)
Modified:
7 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Land Recent QUIC Changes QUIC crypto: move config objects. Currently the client and server configs are setup and torn-down for each connection. Since they are supposed to be per-client and per-server objects, this change makes them parameters that are passed into the connection Merge internal change: 44269387 QUIC crypto steps 6 and 7: per-server strike register. This change adds a per-server strike-register that allows the server to complete 0-RTT connections if the client has enough information cached. Due to the fact that the per-server and per-client objects (QuicCryptoServerConfig and QuicCryptoClientConfig) are currently setup and torn down for each connection, there's no tests in this change for a 0-RTT handshake because we can't do one yet. The next change will move these objects into the right place so that 0-RTT handshakes can be tested. This change also reminded me why I had a server nonce: without it the server cannot terminate any connections if the strike-register fails. So the server nonce is firmly back. Merge internal change: 44228897 R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194634

Patch Set 1 #

Patch Set 2 : Updated copyright notice #

Unified diffs Side-by-side diffs Delta from patch set Stats (+548 lines, -388 lines) Patch
M net/net.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_handshake.h View 14 chunks +33 lines, -18 lines 0 comments Download
M net/quic/crypto/crypto_handshake.cc View 21 chunks +103 lines, -31 lines 0 comments Download
M net/quic/crypto/crypto_handshake_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/crypto_protocol.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_utils.h View 2 chunks +10 lines, -8 lines 0 comments Download
M net/quic/crypto/crypto_utils.cc View 4 chunks +11 lines, -5 lines 0 comments Download
M net/quic/quic_client_session.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/quic_client_session.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M net/quic/quic_client_session_test.cc View 2 chunks +5 lines, -1 line 0 comments Download
A net/quic/quic_config.h View 1 1 chunk +66 lines, -0 lines 0 comments Download
A + net/quic/quic_config.cc View 3 chunks +3 lines, -56 lines 0 comments Download
M net/quic/quic_connection.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_crypto_client_stream.h View 3 chunks +15 lines, -3 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 6 chunks +37 lines, -15 lines 0 comments Download
M net/quic/quic_crypto_client_stream_factory.h View 1 chunk +4 lines, -1 line 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 2 chunks +5 lines, -1 line 0 comments Download
M net/quic/quic_crypto_server_stream.h View 3 chunks +9 lines, -3 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 2 chunks +8 lines, -26 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 2 chunks +7 lines, -1 line 0 comments Download
M net/quic/quic_crypto_stream.h View 1 chunk +0 lines, -48 lines 0 comments Download
M net/quic/quic_crypto_stream.cc View 1 chunk +0 lines, -124 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 2 chunks +5 lines, -1 line 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_reliable_client_stream_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.h View 4 chunks +16 lines, -3 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 4 chunks +24 lines, -5 lines 0 comments Download
M net/quic/quic_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.h View 2 chunks +12 lines, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 4 chunks +36 lines, -2 lines 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream.h View 1 chunk +4 lines, -2 lines 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream_factory.h View 1 chunk +4 lines, -1 line 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream_factory.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client.h View 2 chunks +7 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M net/tools/quic/quic_client_session.h View 1 chunk +3 lines, -1 line 0 comments Download
M net/tools/quic/quic_client_session.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.h View 3 chunks +12 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_reliable_client_stream_test.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/tools/quic/quic_server.h View 2 chunks +10 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server.cc View 4 chunks +24 lines, -2 lines 0 comments Download
M net/tools/quic/quic_server_session.h View 2 chunks +6 lines, -1 line 0 comments Download
M net/tools/quic/quic_server_session.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ramant (doing other things)
7 years, 8 months ago (2013-04-17 03:23:47 UTC) #1
ramant (doing other things)
7 years, 8 months ago (2013-04-17 03:24:41 UTC) #2
Ryan Hamilton
Is this the merge of the two previous CLs? If so, please edit the subject ...
7 years, 8 months ago (2013-04-17 03:25:31 UTC) #3
ramant (doing other things)
On 2013/04/17 03:25:31, Ryan Hamilton wrote: > Is this the merge of the two previous ...
7 years, 8 months ago (2013-04-17 03:30:52 UTC) #4
Ryan Hamilton
lgtm
7 years, 8 months ago (2013-04-17 03:35:17 UTC) #5
ramant (doing other things)
7 years, 8 months ago (2013-04-17 17:57:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r194634 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698