Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 13976002: Deprecation notice added to Desktop Notifications (Closed)

Created:
7 years, 8 months ago by mkearney1
Modified:
7 years, 8 months ago
Reviewers:
dewittj
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, jakearchibald, ericbidelman
Visibility:
Public.

Description

I've added a warning to the top of Desktop Notifications which explains the changes and promotes the new Chrome notifications API. Justin, I reworded this a bit with help from Eric Bidelman (thanks, Eric). Not too sure if this is what you are looking for. Also copied Jake here as per Eric's request as he will be drafting new HTML5 rocks content. BUG=182000 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193422

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/common/extensions/docs/templates/articles/desktop_notifications.html View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dewittj
Could you mention the particular function webkitNotifications.createHTMLNotification as deprecated?
7 years, 8 months ago (2013-04-10 16:35:06 UTC) #1
mkearney1
On 2013/04/10 16:35:06, dewittj wrote: > Could you mention the particular function > webkitNotifications.createHTMLNotification as ...
7 years, 8 months ago (2013-04-10 18:10:19 UTC) #2
mkearney1
Warning has been updated to include deprecated method.
7 years, 8 months ago (2013-04-10 18:10:44 UTC) #3
dewittj
lgtm with one comment https://codereview.chromium.org/13976002/diff/3001/chrome/common/extensions/docs/templates/articles/desktop_notifications.html File chrome/common/extensions/docs/templates/articles/desktop_notifications.html (right): https://codereview.chromium.org/13976002/diff/3001/chrome/common/extensions/docs/templates/articles/desktop_notifications.html#newcode4 chrome/common/extensions/docs/templates/articles/desktop_notifications.html:4: The <code>webKitNotifications.createHTMLNotification()</code> in the probably ...
7 years, 8 months ago (2013-04-10 18:15:05 UTC) #4
mkearney1
7 years, 8 months ago (2013-04-10 18:21:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r193422 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698