Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1397563003: Remove wm_flow, browser, nesting_app examples (Closed)

Created:
5 years, 2 months ago by jamesr
Modified:
5 years, 2 months ago
Reviewers:
viettrungluu, jeffbrown
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove wm_flow, browser, nesting_app examples These aren't used or maintained. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b948ab033f989adec4434b787a2c091de408b586

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1932 lines) Patch
M examples/BUILD.gn View 3 chunks +1 line, -7 lines 0 comments Download
D examples/browser/BUILD.gn View 1 chunk +0 lines, -33 lines 0 comments Download
D examples/browser/browser.cc View 1 chunk +0 lines, -138 lines 0 comments Download
D examples/browser/browser.sky View 1 chunk +0 lines, -42 lines 0 comments Download
D examples/browser/browser_host.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
M examples/moterm_example_app/BUILD.gn View 1 chunk +0 lines, -1 line 2 comments Download
D examples/nesting_app/BUILD.gn View 1 chunk +0 lines, -25 lines 0 comments Download
D examples/nesting_app/nesting_app.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D examples/window_manager/BUILD.gn View 1 chunk +0 lines, -46 lines 0 comments Download
D examples/window_manager/debug_panel.sky View 1 chunk +0 lines, -70 lines 0 comments Download
D examples/window_manager/debug_panel_host.mojom View 1 chunk +0 lines, -18 lines 0 comments Download
D examples/window_manager/window_manager.cc View 1 chunk +0 lines, -560 lines 0 comments Download
D examples/window_manager/window_manager.mojom View 1 chunk +0 lines, -11 lines 0 comments Download
D examples/wm_flow/BUILD.gn View 1 chunk +0 lines, -99 lines 0 comments Download
D examples/wm_flow/app/app.cc View 1 chunk +0 lines, -202 lines 0 comments Download
D examples/wm_flow/app/embedder.mojom View 1 chunk +0 lines, -9 lines 0 comments Download
D examples/wm_flow/embedded/embedded.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D examples/wm_flow/embedded/embeddee.mojom View 1 chunk +0 lines, -9 lines 0 comments Download
D examples/wm_flow/wm/frame_controller.h View 1 chunk +0 lines, -70 lines 0 comments Download
D examples/wm_flow/wm/frame_controller.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D examples/wm_flow/wm/window_frame.sky View 1 chunk +0 lines, -84 lines 0 comments Download
D examples/wm_flow/wm/window_frame_host.mojom View 1 chunk +0 lines, -12 lines 0 comments Download
D examples/wm_flow/wm/wm.cc View 1 chunk +0 lines, -159 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jamesr
https://codereview.chromium.org/1397563003/diff/1/examples/moterm_example_app/BUILD.gn File examples/moterm_example_app/BUILD.gn (left): https://codereview.chromium.org/1397563003/diff/1/examples/moterm_example_app/BUILD.gn#oldcode14 examples/moterm_example_app/BUILD.gn:14: "//examples/window_manager:bindings", trung - I don't understand what this dep ...
5 years, 2 months ago (2015-10-14 23:20:53 UTC) #2
viettrungluu
lgtm https://codereview.chromium.org/1397563003/diff/1/examples/moterm_example_app/BUILD.gn File examples/moterm_example_app/BUILD.gn (left): https://codereview.chromium.org/1397563003/diff/1/examples/moterm_example_app/BUILD.gn#oldcode14 examples/moterm_example_app/BUILD.gn:14: "//examples/window_manager:bindings", On 2015/10/14 23:20:53, jamesr wrote: > trung ...
5 years, 2 months ago (2015-10-15 00:34:02 UTC) #3
jamesr
5 years, 2 months ago (2015-10-15 00:49:48 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b948ab033f989adec4434b787a2c091de408b586 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698