Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1397563002: Setting chrome as the default browser is now fixed on Windows 10 (Closed)

Created:
5 years, 2 months ago by grt (UTC plus 2)
Modified:
5 years, 2 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, vabr+watchlist_chromium.org, asvitkine+watch_chromium.org, Patrick Monette
Base URL:
https://chromium.googlesource.com/chromium/src.git@2526
Target Ref:
refs/pending/branch-heads/2526
Project:
chromium
Visibility:
Public.

Description

Setting chrome as the default browser is now fixed on Windows 10 BUG=531649 Review URL: https://codereview.chromium.org/1349163008 Cr-Commit-Position: refs/heads/master@{#352526} (cherry picked from commit f89ac7c739d5b0ba039af8cabac76a74ff3b2b54) TBR=grt@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/e289a30f0d23d747c1866abe496b427b9eeccac7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+654 lines, -128 lines) Patch
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 1 chunk +16 lines, -7 lines 0 comments Download
M chrome/browser/external_protocol/external_protocol_handler_unittest.cc View 1 chunk +12 lines, -3 lines 0 comments Download
M chrome/browser/shell_integration.h View 7 chunks +116 lines, -47 lines 0 comments Download
M chrome/browser/shell_integration.cc View 7 chunks +192 lines, -65 lines 0 comments Download
M chrome/browser/shell_integration_win.cc View 7 chunks +128 lines, -5 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.h View 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 4 chunks +51 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 2 chunks +68 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +52 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
grt (UTC plus 2)
5 years, 2 months ago (2015-10-07 19:39:14 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e289a30f0d23d747c1866abe496b427b9eeccac7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698