Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1397513004: Don't throw on assignment to function name binding in harmony sloppy mode (Closed)

Created:
5 years, 2 months ago by adamk
Modified:
5 years, 2 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't throw on assignment to function name binding in harmony sloppy mode BUG=v8:4482 LOG=n Committed: https://crrev.com/18534dffc911ec9bd1285f1e9c2e14272e83097c Cr-Commit-Position: refs/heads/master@{#31218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M src/parser.cc View 1 chunk +3 lines, -6 lines 0 comments Download
A test/mjsunit/harmony/regress/regress-4482.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
adamk
5 years, 2 months ago (2015-10-09 23:21:27 UTC) #2
Dan Ehrenberg
lgtm
5 years, 2 months ago (2015-10-09 23:44:18 UTC) #3
rossberg
Just a note that we need a plan for this. We want to get rid ...
5 years, 2 months ago (2015-10-12 08:55:46 UTC) #4
adamk
On 2015/10/12 08:55:46, rossberg wrote: > Just a note that we need a plan for ...
5 years, 2 months ago (2015-10-12 16:32:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397513004/1
5 years, 2 months ago (2015-10-12 16:32:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 16:55:27 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 16:55:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18534dffc911ec9bd1285f1e9c2e14272e83097c
Cr-Commit-Position: refs/heads/master@{#31218}

Powered by Google App Engine
This is Rietveld 408576698