Issue 13975014: Remove freetype dependency from core.gyp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13975014: Remove freetype dependency from core.gyp (Closed)

Created:
7 years, 8 months ago by djsollen

Modified:
7 years, 8 months ago

Reviewers:
bungeman-skia, borenet

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Remove freetype dependency from core.gyp Committed: https://code.google.com/p/skia/source/detail?r=8677 Committed: https://code.google.com/p/skia/source/detail?r=8678

Patch Set 2 : add forward declare for struct #

Patch Set 3 : fix for nacl build #

Patch Set 5 : extra guards #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -10 lines)			Patch
	M	gyp/core.gyp	View	1 2 3	1 chunk	+0 lines, -5 lines	0 comments	Download
	M	src/core/SkAdvancedTypefaceMetrics.cpp	View	1 2 3 4	2 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

bungeman-skia

lgtm wit the one change. https://codereview.chromium.org/13975014/diff/1/src/core/SkAdvancedTypefaceMetrics.cpp File src/core/SkAdvancedTypefaceMetrics.cpp (right): https://codereview.chromium.org/13975014/diff/1/src/core/SkAdvancedTypefaceMetrics.cpp#newcode266 src/core/SkAdvancedTypefaceMetrics.cpp:266: typedef struct FT_FaceRec_* FT_Face; ...

7 years, 8 months ago (2013-04-12 18:16:02 UTC) #2

djsollen

Committed patchset #3 manually as r8677 (presubmit successful).

7 years, 8 months ago (2013-04-15 14:03:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r8678.