Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Side by Side Diff: build/config/BUILD.gn

Issue 1397493004: Move //build/module_args/v8.gni to //build_overrides. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rework README to hopefully be clearer Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/allocator.gni") 5 import("//build/config/allocator.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/crypto.gni") 7 import("//build/config/crypto.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/sanitizers/sanitizers.gni") 9 import("//build/config/sanitizers/sanitizers.gni")
10 import("//build/config/ui.gni") 10 import("//build/config/ui.gni")
11 import("//build/module_args/v8.gni") 11 import("//build_overrides/v8.gni")
kjellander_chromium 2015/10/13 07:31:35 Having this being included in the //build tree wil
Dirk Pranke 2015/10/13 17:11:41 It should feel wrong, because it probably is wrong
12 import("//build/toolchain/goma.gni") 12 import("//build/toolchain/goma.gni")
13 13
14 declare_args() { 14 declare_args() {
15 # When set (the default) enables C++ iterator debugging in debug builds. 15 # When set (the default) enables C++ iterator debugging in debug builds.
16 # Iterator debugging is always off in release builds (technically, this flag 16 # Iterator debugging is always off in release builds (technically, this flag
17 # affects the "debug" config, which is always available but applied by 17 # affects the "debug" config, which is always available but applied by
18 # default only in debug builds). 18 # default only in debug builds).
19 # 19 #
20 # Iterator debugging is generally useful for catching bugs. But it can 20 # Iterator debugging is generally useful for catching bugs. But it can
21 # introduce extra locking to check the state of an iterator against the state 21 # introduce extra locking to check the state of an iterator against the state
(...skipping 427 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 # This error doesn't happen every time. In VS2013, it seems if the .pch 449 # This error doesn't happen every time. In VS2013, it seems if the .pch
450 # file doesn't exist, no error will be generated (probably MS tested this 450 # file doesn't exist, no error will be generated (probably MS tested this
451 # case but forgot the other one?). To reproduce this error, do a build, 451 # case but forgot the other one?). To reproduce this error, do a build,
452 # then delete the precompile.c.obj file, then build again. 452 # then delete the precompile.c.obj file, then build again.
453 cflags_c = [ "/wd4206" ] 453 cflags_c = [ "/wd4206" ]
454 } else if (is_mac && !is_official_build && !use_goma) { 454 } else if (is_mac && !is_official_build && !use_goma) {
455 precompiled_header = "build/precompile.h" 455 precompiled_header = "build/precompile.h"
456 precompiled_source = "//build/precompile.h" 456 precompiled_source = "//build/precompile.h"
457 } 457 }
458 } 458 }
OLDNEW
« no previous file with comments | « BUILD.gn ('k') | build/module_args/v8.gni » ('j') | build_overrides/README.md » ('J')

Powered by Google App Engine
This is Rietveld 408576698