Report the Auth method for me2me connections.

remoting/webapp/base/js/credentials_provider.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 var remoting = remoting || {};
 
 /** @typedef {{clientId: string, sharedSecret: string}} */
 remoting.PairingInfo;
@@ skipping 32 matching lines @@
  */
 remoting.CredentialsProvider = function(args) {
   /** @private */
   this.fetchPin_ = (args.accessCode) ? this.getAccessCode_ : args.fetchPin;
   /** @private */
   this.pairingInfo_ = args.pairingInfo;
   /** @private */
   this.accessCode_ = args.accessCode;
   /** @private */
   this.fetchThirdPartyToken_ = args.fetchThirdPartyToken;
+
+  /** @private {?remoting.ChromotingEvent.AuthMethod} */
+  this.authMethod_ = null;
 };
 
 /** @returns {void}  */
 remoting.CredentialsProvider.prototype.getAccessCode_ = function(
   /** boolean */ supportsPairing, /** Function */ callback) {
+  this.authMethod_ = remoting.ChromotingEvent.AuthMethod.ACCESS_CODE;

[Jamie, 2015/10/08 22:22:42]

This isn't the right place to set this. Aside from the strangeness of having a
getter update state, you're relying on the fact that a caller will never invoke
this method unless the authentication method was ACCESS_CODE. That's a fragile
assumption to make--you'd be better off storing the authMethod field somewhere
else or having an explicit setAuthMethod method on this class.

[kelvinp, 2015/10/09 00:45:41]

I agree that the correct long term fix will be in the plugin layer.
However, that would require reverse the ownership of the authenticator thru a
couple layers, which is quite risky to do after
a branch point.  I will prefer to land this fix now and clean it up
in trunk.

[Jamie, 2015/10/09 01:17:21]

Agreed, thanks for investigating.

[kelvinp, 2015/10/09 18:00:34]

Done.

   callback(this.accessCode_);
 };
 
 /** @returns {remoting.PairingInfo}  */
 remoting.CredentialsProvider.prototype.getPairingInfo = function() {
+  if (this.pairingInfo_) {
+    this.authMethod_ = remoting.ChromotingEvent.AuthMethod.PINLESS;
+  }
   return this.pairingInfo_ || { clientId: '', sharedSecret: ''};
 };
 
 /**
  * @param {boolean} pairingSupported Whether pairing is supported by the host.
  * @returns {Promise<string>}
  */
 remoting.CredentialsProvider.prototype.getPIN = function(pairingSupported) {
   var that = this;
   if (!this.fetchPin_) {
     Promise.resolve('');
   }
+
+  this.authMethod_ = remoting.ChromotingEvent.AuthMethod.PIN;
   return new Promise(function(/** function(string) */ resolve) {
     that.fetchPin_(pairingSupported, resolve);
   });
 };
 
 /**
  * @param {string} tokenUrl Token-issue URL received from the host.
  * @param {string} hostPublicKey Host public key (DER and Base64 encoded).
  * @param {string} scope OAuth scope to request the token for.
  *
  * @returns {Promise<remoting.ThirdPartyToken>}
  */
 remoting.CredentialsProvider.prototype.getThirdPartyToken = function(
     tokenUrl, hostPublicKey, scope) {
   var that = this;
   if (!this.fetchThirdPartyToken_) {
     Promise.resolve({token: '', secret: ''});
   }
+
+  this.authMethod_ = remoting.ChromotingEvent.AuthMethod.THIRD_PARTY;
   return new Promise(function(/** Function */ resolve) {
     var onTokenFetched = function(/** string */ token, /** string */ secret) {
       resolve({token: token, secret: secret});
     };
     that.fetchThirdPartyToken_(tokenUrl, hostPublicKey, scope, onTokenFetched);
   });
 };
+
+/** @return {?remoting.ChromotingEvent.AuthMethod} */
+remoting.CredentialsProvider.prototype.getAuthMethod = function() {
+  return this.authMethod_;
+};