Report the Auth method for me2me connections.

remoting/webapp/base/js/client_session.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class handling creation and teardown of a remoting client session.
  *
  * The ClientSession class controls lifetime of the client plugin
  * object and provides the plugin with the functionality it needs to
@@ skipping 532 matching lines @@
         new base.RepeatingTimer(this.reportStatistics.bind(this), 1000));
     if (this.plugin_.hasCapability(
           remoting.ClientSession.Capability.TOUCH_EVENTS)) {
       this.plugin_.enableTouchEvents(true);
     }
   } else if (this.isFinished()) {
     base.dispose(this.connectedDisposables_);
     this.connectedDisposables_ = null;
   }
 
+  this.logAuthMethod_();
   this.notifyStateChanges_(oldState, this.state_);
   // Record state count in an UMA enumerated histogram.
   recordState(this.state_);
   this.logger_.logClientSessionStateChange(
       this.state_, this.error_, this.xmppErrorCache_.getFirstError());
 };
 
+/** @private */
+remoting.ClientSession.prototype.logAuthMethod_ = function() {
+  // The AuthMethod is undefined before the AUTHENTICATED stage for a
+  // successful connection or the FAILED stage for a failed connection.
+  if (this.state_ == remoting.ClientSession.State.AUTHENTICATED ||
+      this.state_ == remoting.ClientSession.State.FAILED) {

[Jamie, 2015/10/09 01:17:21]

Rather than relying on this, couldn't you have getAuthMethod return null? Feel
free to ignore if this code will change substantially when you refactor the
plugin code to notify the auth method explicitly.

[kelvinp, 2015/10/09 18:00:34]

The scenario that I am trying to cover is the following:

If you have a pairing info in local storage (but pairing is disabled on the host
side), we will always read the pairing info from the credentials provider the
session.  Due to the limitations that you have pointed out before, the session
will be first reported with pairing as the auth method.  However, upon
authentication, it fails and the host will ask for a PIN.  As a result, the
CONNECTING events of the session will be reported using pairing whereas
AUTHENTICATED will be reported using PIN.

+    var authMethod = this.credentialsProvider_.getAuthMethod();
+    if (authMethod != null) {
+      this.logger_.setAuthMethod(authMethod);
+    }
+  }
+};
+
 /**
  * Records a Chromoting Connection State, stored in an UMA enumerated histogram.
  * @param {remoting.ClientSession.State} state State identifier.
  */
 function recordState(state) {
   // According to src/base/metrics/histogram.h, for a UMA enumerated histogram,
   // the upper limit should be 1 above the max-enum.
   var histogram_max = remoting.ClientSession.State.MAX_STATE_ENUM -
       remoting.ClientSession.State.MIN_STATE_ENUM + 1;
 
@@ skipping 83 matching lines @@
   } else if (previous == State.CONNECTED && current == State.FAILED) {
     return State.CONNECTION_DROPPED;
   }
   return current;
 };
 
 /** @private */
 remoting.ClientSession.prototype.reportStatistics = function() {
   this.logger_.logStatistics(this.plugin_.getPerfStats());
 };