Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1397443013: [es6] Implement Reflect.enumerate. (Closed)

Created:
5 years, 2 months ago by neis
Modified:
5 years, 2 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Implement Reflect.enumerate. R=rossberg BUG=v8:3931 LOG=n Committed: https://crrev.com/2ed1eebe9ff1804afcfb563bd51ef44e76629755 Cr-Commit-Position: refs/heads/master@{#31299}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -108 lines) Patch
M src/js/harmony-reflect.js View 2 chunks +9 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/reflect.js View 1 chunk +20 lines, -0 lines 0 comments Download
A + test/mjsunit/harmony/reflect-enumerate.js View 4 chunks +14 lines, -46 lines 0 comments Download
A + test/mjsunit/harmony/reflect-enumerate-delete.js View 2 chunks +7 lines, -4 lines 0 comments Download
A + test/mjsunit/harmony/reflect-enumerate-opt.js View 3 chunks +6 lines, -15 lines 0 comments Download
A + test/mjsunit/harmony/reflect-enumerate-special-cases.js View 4 chunks +8 lines, -41 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
neis
PTAL. A comment on tests: test262 has a bunch of tests for Reflect, including Reflect.enumerate. ...
5 years, 2 months ago (2015-10-15 08:40:49 UTC) #1
rossberg
lgtm
5 years, 2 months ago (2015-10-15 12:05:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397443013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397443013/1
5 years, 2 months ago (2015-10-15 12:09:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 12:59:32 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 12:59:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ed1eebe9ff1804afcfb563bd51ef44e76629755
Cr-Commit-Position: refs/heads/master@{#31299}

Powered by Google App Engine
This is Rietveld 408576698