Issue 1397443002: Make MojoShellActivity ephemeral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1397443002: Make MojoShellActivity ephemeral. (Closed)

Created:
5 years, 2 months ago by etiennej

Modified:
5 years, 2 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make MojoShellActivity ephemeral. Restore Theme.NoDisplay as the MojoShellActivity theme. Refactor the activity so that it can be finished at the end of onCreate, so it never reaches the recents screen. R=qsr@chromium.org, qsr Committed: https://chromium.googlesource.com/external/mojo/+/c27981ed8de58af35609a69172c0ecd1eabe72c3

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -51 lines)			Patch
M	shell/android/apk/AndroidManifest.xml.jinja2	View	1 chunk	+1 line, -1 line	0 comments	Download
M	shell/android/apk/src/org/chromium/mojo/shell/MojoShellActivity.java	View	2 chunks	+6 lines, -50 lines	0 comments	Download
M	shell/android/apk/src/org/chromium/mojo/shell/ShellService.java	View	3 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

etiennej

5 years, 2 months ago (2015-10-07 15:21:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c27981ed8de58af35609a69172c0ecd1eabe72c3 (presubmit successful).

Expand Messages | Collapse Messages