Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1397443002: Make MojoShellActivity ephemeral. (Closed)

Created:
5 years, 2 months ago by etiennej
Modified:
5 years, 2 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make MojoShellActivity ephemeral. Restore Theme.NoDisplay as the MojoShellActivity theme. Refactor the activity so that it can be finished at the end of onCreate, so it never reaches the recents screen. R=qsr@chromium.org, qsr Committed: https://chromium.googlesource.com/external/mojo/+/c27981ed8de58af35609a69172c0ecd1eabe72c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -51 lines) Patch
M shell/android/apk/AndroidManifest.xml.jinja2 View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/apk/src/org/chromium/mojo/shell/MojoShellActivity.java View 2 chunks +6 lines, -50 lines 0 comments Download
M shell/android/apk/src/org/chromium/mojo/shell/ShellService.java View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
etiennej
5 years, 2 months ago (2015-10-07 14:17:02 UTC) #1
qsr
Very nice. Thanks. LGTM
5 years, 2 months ago (2015-10-07 14:45:42 UTC) #2
etiennej
5 years, 2 months ago (2015-10-07 15:21:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c27981ed8de58af35609a69172c0ecd1eabe72c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698