Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Issue 139743011: Change ContentLinker to share relro sections with browser process only on low-end devices. (Closed)

Created:
6 years, 11 months ago by Yaron
Modified:
6 years, 10 months ago
Reviewers:
palmer, klobag.chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Change ContentLinker to share relro sections with browser process only on low-end devices. While this change increases memory usage on non low-end devices, the impact is small enough that we can limit the exposure surface to only where it makes a signficant impact. Also adds content_linker_test_apk to the android builders to ensure it doesn't regress. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247622

Patch Set 1 #

Patch Set 2 : fix content_linker_test build #

Patch Set 3 : fix findbugs #

Patch Set 4 : rebase #

Patch Set 5 : fix gyp location #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -13 lines) Patch
M build/all.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/app/Linker.java View 1 3 chunks +3 lines, -1 line 0 comments Download
M content/shell/android/linker_test_apk/src/org/chromium/content_linker_test_apk/ContentLinkerTestActivity.java View 1 2 2 chunks +20 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Yaron
6 years, 11 months ago (2014-01-22 01:55:34 UTC) #1
digit1
I'm ok with the patch, but did you run the content linker unittests as well ...
6 years, 11 months ago (2014-01-22 04:10:46 UTC) #2
Yaron
So.. that target didn't actually compile because the bots don't build it. Fixed compilation and ...
6 years, 11 months ago (2014-01-22 18:32:17 UTC) #3
palmer
LGTM. Thanks!
6 years, 11 months ago (2014-01-24 03:10:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/139743011/140001
6 years, 11 months ago (2014-01-28 02:51:06 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=217070
6 years, 11 months ago (2014-01-28 03:08:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/139743011/140001
6 years, 10 months ago (2014-01-28 21:40:50 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=172284
6 years, 10 months ago (2014-01-28 22:13:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/139743011/160001
6 years, 10 months ago (2014-01-29 00:47:05 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 05:12:28 UTC) #10
Message was sent while issue was closed.
Change committed as 247622

Powered by Google App Engine
This is Rietveld 408576698