Issue 139743010: Remove more unnamed namespace usages.

Issue 139743010: Remove more unnamed namespace usages. (Closed)

Created:
6 years, 11 months ago by tfarina

Modified:
6 years, 11 months ago

Reviewers:
bsalomon, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Remove more unnamed namespace usages. Skia prefers 'static' over 'unnamed' namespaces. BUG=None TEST=skgpu and tools R=robertphillips@google.com, bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=13146

Patch Set 2 : align #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -20 lines)			Patch
M	experimental/StrokePathRenderer/GrStrokePathRenderer.cpp	View	1	3 chunks	+4 lines, -8 lines	0 comments	Download
M	tools/picture_utils.cpp	View		2 chunks	+8 lines, -10 lines	0 comments	Download
M	tools/render_pictures_main.cpp	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina

Brian, Robert, can either of you review this to me? Thanks,

6 years, 11 months ago (2014-01-22 01:38:36 UTC) #1

robertphillips

lgtm + 1 nit https://codereview.chromium.org/139743010/diff/1/experimental/StrokePathRenderer/GrStrokePathRenderer.cpp File experimental/StrokePathRenderer/GrStrokePathRenderer.cpp (right): https://codereview.chromium.org/139743010/diff/1/experimental/StrokePathRenderer/GrStrokePathRenderer.cpp#newcode25 experimental/StrokePathRenderer/GrStrokePathRenderer.cpp:25: const SkPoint& p3, const SkPoint& ...

6 years, 11 months ago (2014-01-22 12:44:09 UTC) #2

tfarina

https://codereview.chromium.org/139743010/diff/1/experimental/StrokePathRenderer/GrStrokePathRenderer.cpp File experimental/StrokePathRenderer/GrStrokePathRenderer.cpp (right): https://codereview.chromium.org/139743010/diff/1/experimental/StrokePathRenderer/GrStrokePathRenderer.cpp#newcode25 experimental/StrokePathRenderer/GrStrokePathRenderer.cpp:25: const SkPoint& p3, const SkPoint& p4, On 2014/01/22 12:44:09, ...

6 years, 11 months ago (2014-01-23 02:02:39 UTC) #3

tfarina

6 years, 11 months ago (2014-01-23 02:03:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r13146 (presubmit successful).

Expand Messages | Collapse Messages