Replace RenderFullScreen with top layer

Source/core/html/HTMLDialogElement.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 77 matching lines @@
     topDocument->clearAXObjectCache();
     if (AXObjectCache* cache = topDocument->axObjectCache())
         cache->childrenChanged(cache->getOrCreate(topDocument));
 }
 
 HTMLDialogElement::HTMLDialogElement(Document& document)
     : HTMLElement(dialogTag, document)
     , m_centeringMode(Uninitialized)
     , m_centeredPosition(0)
     , m_returnValue("")
+    , m_modal(false)
 {
     ScriptWrappable::init(this);
 }
 
 PassRefPtr<HTMLDialogElement> HTMLDialogElement::create(Document& document)
 {
     return adoptRef(new HTMLDialogElement(document));
 }
 
 void HTMLDialogElement::close(const String& returnValue, ExceptionState& exceptionState)
 {
     if (!fastHasAttribute(openAttr)) {
         exceptionState.throwDOMException(InvalidStateError, "The element does not have an 'open' attribute, and therefore cannot be closed.");
         return;
     }
     closeDialog(returnValue);
 }
 
+void HTMLDialogElement::removedFrom(ContainerNode* insertionPoint)
+{
+    document().removeFromModalDialogStack(this);

[esprehn, 2014/01/21 18:59:05]

Remove all this, I don't think you should need the special
removeFromModalDialogStack logic, just make the getter dynamic.

[falken, 2014/01/22 06:08:02]

OK but we still need removedFrom to reset m_modal. Otherwise, if you remove a
modal dialog, then add it back and make it fullscreen, it will be treated as a
modal. The spec says when a dialog is removed, it loses modality.

+    HTMLElement::removedFrom(insertionPoint);
+}
+
 void HTMLDialogElement::closeDialog(const String& returnValue)
 {
     if (!fastHasAttribute(openAttr))
         return;
     setBooleanAttribute(openAttr, false);
 
     HTMLDialogElement* activeModalDialog = document().activeModalDialog();
-    document().removeFromTopLayer(this);
+    document().removeFromModalDialogStack(this);
     if (activeModalDialog == this)
         inertSubtreesChanged(document());
 
     if (!returnValue.isNull())
         m_returnValue = returnValue;
 
     dispatchScopedEvent(Event::create(EventTypeNames::close));
 }
 
 void HTMLDialogElement::forceLayoutForCentering()
@@ skipping 16 matching lines @@
 {
     if (fastHasAttribute(openAttr)) {
         exceptionState.throwDOMException(InvalidStateError, "The element already has an 'open' attribute, and therefore cannot be opened modally.");
         return;
     }
     if (!inDocument()) {
         exceptionState.throwDOMException(InvalidStateError, "The element is not in a Document.");
         return;
     }
 
-    document().addToTopLayer(this);
+    document().addToModalDialogStack(this);
     setBooleanAttribute(openAttr, true);
 
     // Throw away the AX cache first, so the subsequent steps don't have a chance of queuing up
     // AX events on objects that would be invalidated when the cache is thrown away.
     inertSubtreesChanged(document());
 
     forceLayoutForCentering();
     setFocusForModalDialog(this);
 }
 
@@ skipping 24 matching lines @@
 {
     if (event->type() == EventTypeNames::cancel) {
         closeDialog();
         event->setDefaultHandled();
         return;
     }
     HTMLElement::defaultEventHandler(event);
 }
 
 } // namespace WebCore