Replace RenderFullScreen with top layer

Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
@@ skipping 432 matching lines @@
     , m_documentClasses(documentClasses)
     , m_isViewSource(false)
     , m_sawElementsInKnownNamespaces(false)
     , m_isSrcdocDocument(false)
     , m_isMobileDocument(false)
     , m_mayDisplaySeamlesslyWithParent(false)
     , m_renderView(0)
     , m_weakFactory(this)
     , m_contextDocument(initializer.contextDocument())
     , m_hasFullscreenElementStack(false)
+    , m_activeModalDialog(0)
     , m_loadEventDelayCount(0)
     , m_loadEventDelayTimer(this, &Document::loadEventDelayTimerFired)
     , m_referrerPolicy(ReferrerPolicyDefault)
     , m_directionSetOnDocumentElement(false)
     , m_writingModeSetOnDocumentElement(false)
     , m_writeRecursionIsTooDeep(false)
     , m_writeRecursionDepth(0)
     , m_lastHandledUserGestureTimestamp(0)
     , m_taskRunner(MainThreadTaskRunner::create(this))
     , m_registrationContext(initializer.registrationContext(this))
@@ skipping 4307 matching lines @@
 void Document::removeFromTopLayer(Element* element)
 {
     if (!element->isInTopLayer())
         return;
     size_t position = m_topLayerElements.find(element);
     ASSERT(position != kNotFound);
     m_topLayerElements.remove(position);
     element->setIsInTopLayer(false);
 }
 
+void Document::addToModalDialogStack(HTMLDialogElement* dialog)
+{
+    if (dialog->isModal())
+        return;
+    addToTopLayer(dialog);
+    dialog->setModal(true);
+    m_activeModalDialog = dialog;
+}
+
+void Document::removeFromModalDialogStack(HTMLDialogElement* dialog)
+{
+    if (!dialog->isModal())
+        return;
+    removeFromTopLayer(dialog);
+    dialog->setModal(false);
+
+    if (m_activeModalDialog != dialog)
+        return;
+    m_activeModalDialog = 0;

[esprehn, 2014/01/21 18:59:05]

Document::activeModalDialog() should just contain a loop, get rid of the field
and the updating below.

[falken, 2014/01/22 06:08:02]

Done.

+    Vector<RefPtr<Element> >::reverse_iterator end = m_topLayerElements.rend();
+    for (Vector<RefPtr<Element> >::reverse_iterator it = m_topLayerElements.rbegin(); it != end; ++it) {
+        if (!it->get()->hasTagName(dialogTag))
+            continue;
+        HTMLDialogElement* dialog = toHTMLDialogElement(it->get());
+        if (dialog->isModal()) {
+            m_activeModalDialog = dialog;
+            return;
+        }
+    }
+}
+
 HTMLDialogElement* Document::activeModalDialog() const
 {
-    if (m_topLayerElements.isEmpty())
-        return 0;
-    return toHTMLDialogElement(m_topLayerElements.last().get());
+    return m_activeModalDialog;

[esprehn, 2014/01/21 18:59:05]

This should contain the loop.

 }
 
 void Document::webkitExitPointerLock()
 {
     if (!page())
         return;
     if (Element* target = page()->pointerLockController().element()) {
         if (target->document() != this)
             return;
     }
@@ skipping 498 matching lines @@
     if (!element) {
         m_autofocusElement = 0;
         return;
     }
     if (!m_autofocusElement)
         m_taskRunner->postTask(AutofocusTask::create());
     m_autofocusElement = element;
 }
 
 } // namespace WebCore