Flag TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305 as using ECDHE_ECDSA key exchange

Flag TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305 as using ECDHE_ECDSA key exchange

BUG=336328
TEST=Navigate to a site that negotiates
TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305 (eg: https://www.gmail.com )
and, if TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305 is negotiated, confirm
that the key exchange algorithm is listed as ECDHE_ECDSA with the
encryption/authentication alg as CHACHA20_POLY1305

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246001

[Ryan Sleevi, 2014-01-21 06:41:51]

wtc: Easy review. Off by one. - 0x0d = 13 =
https://code.google.com/p/chromium/codesearch#chromium/src/net/ssl/ssl_cipher...

0x0e = 14 = ECDHE_ECDSA

The cipher suite name gives it away :)

[Ryan Sleevi, 2014-01-21 06:42:03]

sorry, that s/wtc/davidben :)

[davidben, 2014-01-21 06:54:35]

On 2014/01/21 06:42:03, Ryan Sleevi wrote:
> sorry, that s/wtc/davidben :)

LGTM

[commit-bot: I haz the power, 2014-01-21 06:55:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/139743003/1

[commit-bot: I haz the power, 2014-01-21 08:53:07]

Change committed as 246001

[wtc, 2014-01-21 18:10:55]

Patch set 1 LGTM.

Adam, should we add the ssl_cipher_suite_names_generate.go program back to the
Chromium source tree?

https://codereview.chromium.org/139743003/diff/1/net/ssl/ssl_cipher_suite_nam...
File net/ssl/ssl_cipher_suite_names.cc (right):

https://codereview.chromium.org/139743003/diff/1/net/ssl/ssl_cipher_suite_nam...
net/ssl/ssl_cipher_suite_names.cc:25: // The following tables were generated by
ssl_cipher_suite_names_generate.go,

The entries in these tables were originally generated by a Go program. But the
Go program was removed from the Chromium source tree.

https://codereview.chromium.org/139743003/diff/1/net/ssl/ssl_cipher_suite_nam...
net/ssl/ssl_cipher_suite_names.cc:198: {0xcc14, 0x0e8f},  //
TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305

Hmm... based on the lack of leading 0 digit in all the other TLS_ECDHS_ECDSA_xxx
entries, I think Adam generated these two entries manually.

[agl, 2014-01-21 22:18:05]

On 2014/01/21 18:10:55, wtc wrote:
> Patch set 1 LGTM.
> 
> Adam, should we add the ssl_cipher_suite_names_generate.go program back to the
> Chromium source tree?

That would be nice, I think it's still banned :(