build/android/gyp/javac.py - Issue 1397423005: GN: Fix enable_incremental_javac never recompiling changes to .srcjars

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/javac.py

Issue 1397423005: GN: Fix enable_incremental_javac never recompiling changes to .srcjars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/gyp/javac.py

diff --git a/build/android/gyp/javac.py b/build/android/gyp/javac.py

index 65b36a54dfe643ec783f050eb2c4e7ca775d41b0..c33300a8e07597875fb010ad1726ae7dae6bc8f5 100755

--- a/build/android/gyp/javac.py

+++ b/build/android/gyp/javac.py

@@ -209,7 +209,8 @@ def _OnStaleMd5(changes, options, javac_cmd, java_files, classpath_inputs,

os.makedirs(java_dir)

for srcjar in options.java_srcjars:

if changed_paths:

- changed_paths.update(changes.IterChangedSubpaths(srcjar))

+ changed_paths.update(os.path.join(java_dir, f)

+ for f in changes.IterChangedSubpaths(srcjar))

build_utils.ExtractAll(srcjar, path=java_dir, pattern='*.java')

jar_srcs = build_utils.FindInDirectory(java_dir, '*.java')

jar_srcs = _FilterJavaFiles(jar_srcs, options.javac_includes)

« no previous file with comments | « no previous file | no next file » | no next file with comments »