third_party/WebKit/Source/platform/fonts/SimpleFontData.h - Issue 1397423004: Improve shaping segmentation for grapheme cluster based font fallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/SimpleFontData.h

Issue 1397423004: Improve shaping segmentation for grapheme cluster based font fallback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge TestExpectations with the HarfBuzz rebaselines Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp ('k') | third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/SimpleFontData.h

diff --git a/third_party/WebKit/Source/platform/fonts/SimpleFontData.h b/third_party/WebKit/Source/platform/fonts/SimpleFontData.h

index ff2c27b3fc1f4f897023b76ddb28ad8d9d42ab1b..ed691d72e45c0dbf0c854f036bf776f33cba91e0 100644

--- a/third_party/WebKit/Source/platform/fonts/SimpleFontData.h

+++ b/third_party/WebKit/Source/platform/fonts/SimpleFontData.h

@@ -182,7 +182,6 @@ private:

mutable OwnPtr<DerivedFontData> m_derivedFontData;

RefPtr<CustomFontData> m_customFontData;

- mutable OwnPtr<HashMap<String, bool>> m_combiningCharacterSequenceSupport;

};

ALWAYS_INLINE FloatRect SimpleFontData::boundsForGlyph(Glyph glyph) const