third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxDialog.js - Issue 1397403003: [DevTools] Remove HelpScreen, turn SettingsScreen into dialog and web component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxDialog.js

Issue 1397403003: [DevTools] Remove HelpScreen, turn SettingsScreen into dialog and web component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@screens

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemDialog.js ('k') | third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js » ('j') | third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxDialog.js

diff --git a/third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxDialog.js b/third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxDialog.js

index 64ce3f4c37bc2b6b4d82a936fd315807f60b2103..e6dd0fae7c7a73e99e84be974e4577851a29b043 100644

--- a/third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxDialog.js

+++ b/third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxDialog.js

@@ -11,6 +11,7 @@

WebInspector.FrameworkBlackboxDialog = function()

{

WebInspector.VBox.call(this);

yurys 2015/10/13 00:52:11 Should we make this a component too?

dgozman 2015/10/13 01:57:42 Not that easy to do - requires splitting settingsS

+ this.registerRequiredCSS("settings/settingsScreen.css");

this.element.classList.add("blackbox-dialog", "dialog-contents", "settings-dialog", "settings-tab");

this.element.addEventListener("keydown", this._onKeyDown.bind(this), false);