Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1397403003: [DevTools] Remove HelpScreen, turn SettingsScreen into dialog and web component. (Closed)

Created:
5 years, 2 months ago by dgozman
Modified:
5 years, 2 months ago
Reviewers:
pfeldman, yurys, samli
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org, yurys, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@screens
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove HelpScreen, turn SettingsScreen into dialog and web component. BUG=none Committed: https://crrev.com/21ec75b5adcb204fa9a97553e859eaa4183ba76e Cr-Commit-Position: refs/heads/master@{#354866}

Patch Set 1 #

Total comments: 6

Patch Set 2 : markAsRoot #

Total comments: 2

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -878 lines) Patch
M third_party/WebKit/Source/devtools/devtools.gypi View 1 2 3 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/inspectorStyle.css View 1 2 1 chunk +0 lines, -52 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxSettingsTab.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js View 1 2 6 chunks +18 lines, -52 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/module.json View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/settings/settingsScreen.css View 1 2 5 chunks +10 lines, -51 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/HelpScreen.js View 1 chunk +0 lines, -120 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 1 2 3 chunks +11 lines, -7 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/helpScreen.css View 1 2 1 chunk +0 lines, -592 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css View 1 chunk +52 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/module.json View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
dgozman
Take a look please.
5 years, 2 months ago (2015-10-12 23:25:46 UTC) #2
yurys
https://codereview.chromium.org/1397403003/diff/1/third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxDialog.js File third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxDialog.js (right): https://codereview.chromium.org/1397403003/diff/1/third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxDialog.js#newcode13 third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxDialog.js:13: WebInspector.VBox.call(this); Should we make this a component too? https://codereview.chromium.org/1397403003/diff/1/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js ...
5 years, 2 months ago (2015-10-13 00:52:11 UTC) #3
dgozman
https://codereview.chromium.org/1397403003/diff/1/third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxDialog.js File third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxDialog.js (right): https://codereview.chromium.org/1397403003/diff/1/third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxDialog.js#newcode13 third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxDialog.js:13: WebInspector.VBox.call(this); On 2015/10/13 00:52:11, yurys wrote: > Should we ...
5 years, 2 months ago (2015-10-13 01:57:42 UTC) #4
yurys
lgtm https://codereview.chromium.org/1397403003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js File third_party/WebKit/Source/devtools/front_end/ui/Dialog.js (right): https://codereview.chromium.org/1397403003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js#newcode92 third_party/WebKit/Source/devtools/front_end/ui/Dialog.js:92: WebInspector.Dialog._instances.pop(); I'd rather avoid nested dialogs and have ...
5 years, 2 months ago (2015-10-13 17:06:18 UTC) #5
dgozman
https://codereview.chromium.org/1397403003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js File third_party/WebKit/Source/devtools/front_end/ui/Dialog.js (right): https://codereview.chromium.org/1397403003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js#newcode92 third_party/WebKit/Source/devtools/front_end/ui/Dialog.js:92: WebInspector.Dialog._instances.pop(); On 2015/10/13 17:06:18, yurys wrote: > I'd rather ...
5 years, 2 months ago (2015-10-19 20:08:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397403003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397403003/40001
5 years, 2 months ago (2015-10-19 20:10:35 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-19 21:18:18 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/21ec75b5adcb204fa9a97553e859eaa4183ba76e Cr-Commit-Position: refs/heads/master@{#354866}
5 years, 2 months ago (2015-10-19 21:19:15 UTC) #11
samli
5 years, 2 months ago (2015-10-20 00:18:27 UTC) #13
Message was sent while issue was closed. 
This broke hidden experiments.

Powered by Google App Engine
This is Rietveld 408576698