Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1397403002: Return 'null' rename refactoring in case of a null element. (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Return 'null' rename refactoring in case of a null element. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/307438d5828bc177baf4e5fb72177da12bb7772e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/refactoring.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 2 months ago (2015-10-12 14:40:26 UTC) #1
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-10-12 17:06:40 UTC) #2
scheglov
5 years, 2 months ago (2015-10-12 17:44:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
307438d5828bc177baf4e5fb72177da12bb7772e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698