Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1397363005: Make the mojom files under //mojo/services/network/interfaces basically the same as the ones in the… (Closed)

Created:
5 years, 2 months ago by viettrungluu
Modified:
5 years, 2 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/monet.git@master
Target Ref:
refs/heads/master
Project:
monet
Visibility:
Public.

Description

Make the mojom files under //mojo/services/network/interfaces basically the same as the ones in the mojo repo. Now, as far as I know, the only difference is that the ones in the mojo repo still have "public". * Add the appropriate directory to the import path, so that "third_party/..." is no longer needed in imports. * Add the DartPackage="mojo_services" annotation to module statements. * Remove one spurious import. The BUILD.gn file isn't the same. I'll ponder ways of fixing this, but it's not a super high priority. R=jamesr@chromium.org Committed: https://github.com/domokit/monet7da2f1903fdbb9607576cec9d9c4107b08ff84b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -15 lines) Patch
M mojo/services/network/interfaces/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/services/network/interfaces/cookie_store.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/interfaces/host_resolver.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/services/network/interfaces/http_connection.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/services/network/interfaces/http_message.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/services/network/interfaces/http_server.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/interfaces/net_address.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/interfaces/network_service.mojom View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/services/network/interfaces/tcp_bound_socket.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/services/network/interfaces/tcp_connected_socket.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/interfaces/tcp_server_socket.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/services/network/interfaces/udp_socket.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/services/network/interfaces/url_loader.mojom View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/network/interfaces/url_loader_interceptor.mojom View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/services/network/interfaces/web_socket.mojom View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 2 months ago (2015-10-13 00:07:27 UTC) #1
jamesr
lgtm to unify the BUILD.gn file we'd need to make the mojom template more configurable ...
5 years, 2 months ago (2015-10-13 00:31:40 UTC) #2
viettrungluu
5 years, 2 months ago (2015-10-13 01:21:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7da2f1903fdbb9607576cec9d9c4107b08ff84b7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698