Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 1397353002: Fix manual editing of integration_test_methods.dart. (Closed)

Created:
5 years, 2 months ago by Paul Berry
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix manual editing of integration_test_methods.dart. In commit 9ad256cf18bc086e27a32e0e5fa8a6a694a36d1a, integration_test_methods.dart (an auto-generated file) was edited manually. The only necessary changes were to imports--the other changes were the result of sorting declarations and running the formatter. This CL replicates the necessary changes in the code generator and re-runs it, un-doing the other changes. This should fix the test "pkg/analysis_server/tool/spec/check_all_test". R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/97676345647a7dbd45f7cf19180287fc19812dbd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+996 lines, -1041 lines) Patch
M pkg/analysis_server/test/integration/integration_test_methods.dart View 9 chunks +994 lines, -1040 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_inttest_methods.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 2 months ago (2015-10-12 12:44:18 UTC) #2
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-10-12 13:15:15 UTC) #3
Paul Berry
5 years, 2 months ago (2015-10-12 13:49:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
97676345647a7dbd45f7cf19180287fc19812dbd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698