PDF Printing: embed browser user agent string in PDF metadata.

printing/print_settings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "printing/print_settings.h"
 
 #include "base/atomic_sequence_num.h"
 #include "base/logging.h"
 #include "printing/print_job_constants.h"
 #include "printing/units.h"
 
 namespace printing {
 
+std::string g_user_agent;

[Lei Zhang, 2015/11/05 21:37:23]

I think this creates a static initializer. You probably want to wrap it in a
LazyInstance.

[hal.canary, 2015/11/05 22:16:48]

done

+void SetAgent(const std::string& user_agent) {
+    g_user_agent = user_agent;

[Lei Zhang, 2015/11/05 21:37:23]

2 space indents, not 4.

[hal.canary, 2015/11/05 22:16:48]

done

+}
+const std::string& GetAgent() {
+    return g_user_agent;
+}
+
+
 #if defined(USE_CUPS)
 void GetColorModelForMode(
     int color_mode, std::string* color_setting_name, std::string* color_value) {
 #if defined(OS_MACOSX)
   const char kCUPSColorMode[] = "ColorMode";
   const char kCUPSColorModel[] = "ColorModel";
   const char kCUPSPrintoutMode[] = "PrintoutMode";
   const char kCUPSProcessColorModel[] = "ProcessColorModel";
 #else
   const char kCUPSColorMode[] = "cups-ColorMode";
@@ skipping 202 matching lines @@
 }
 
 void PrintSettings::SetOrientation(bool landscape) {
   if (landscape_ != landscape) {
     landscape_ = landscape;
     page_setup_device_units_.FlipOrientation();
   }
 }
 
 }  // namespace printing