Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 139733002: Don't load PPAPI O3D. (Closed)

Created:
6 years, 11 months ago by Jorge Lucangeli Obes
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Don't load PPAPI O3D. BUG=334711 TEST=Build on Chrome OS, check about:plugins, O3D is not there. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245276

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M chrome/common/chrome_content_client.cc View 2 chunks +0 lines, -28 lines 0 comments Download
M chrome/common/chrome_paths.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_paths.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jorge Lucangeli Obes
Wheee O3D is out!
6 years, 11 months ago (2014-01-15 17:47:26 UTC) #1
noahric
LGTM. Added Tristan just as a heads up.
6 years, 11 months ago (2014-01-15 18:18:09 UTC) #2
Jorge Lucangeli Obes
+Scott for OWNERS review on chrome/common
6 years, 11 months ago (2014-01-15 18:36:20 UTC) #3
Josh Horwich
LGTM as well
6 years, 11 months ago (2014-01-15 19:28:38 UTC) #4
sky
LGTM
6 years, 11 months ago (2014-01-15 21:28:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jorgelo@chromium.org/139733002/1
6 years, 11 months ago (2014-01-15 23:23:57 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 19:24:36 UTC) #7
Message was sent while issue was closed.
Change committed as 245276

Powered by Google App Engine
This is Rietveld 408576698