Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: pkg/scheduled_test/test/scheduled_test/set_up_test.dart

Issue 13973021: Retrying the setUp/tearDown chaining change. This is the same as r21819 but with a change to schedu… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/scheduled_test/test/scheduled_test/set_up_test.dart
===================================================================
--- pkg/scheduled_test/test/scheduled_test/set_up_test.dart (revision 21853)
+++ pkg/scheduled_test/test/scheduled_test/set_up_test.dart (working copy)
@@ -79,7 +79,7 @@
test('test 2', () => expect(onExceptionRun, isTrue));
}, passing: ['test 2']);
- expectTestsPass("setUp doesn't apply to child groups", () {
+ expectTestsPass("setUp applies to child groups", () {
var setUpRun = false;
setUp(() {
setUpRun = true;
@@ -94,7 +94,7 @@
group('group', () {
test('inner', () {
- expect(setUpRun, isFalse);
+ expect(setUpRun, isTrue);
});
});
});
@@ -140,4 +140,41 @@
});
});
});
-}
+
+ expectTestsPass("setUp calls are chained", () {
+ var setUpOuterRun = false;
+ var setUpInnerRun = false;
+ group('outer group', () {
+ setUp(() {
+ setUpOuterRun = true;
+ currentSchedule.onComplete.schedule(() {
+ setUpOuterRun = false;
+ });
+ });
+ group('intermediate group with no setUp', () {
+ group('inner group', () {
+ setUp(() {
+ setUpInnerRun = true;
+ currentSchedule.onComplete.schedule(() {
+ setUpInnerRun = false;
+ });
+ });
+ test('inner', () {
+ expect(setUpOuterRun, isTrue);
+ expect(setUpInnerRun, isTrue);
+ });
+ });
+ });
+ test('outer', () {
+ expect(setUpOuterRun, isTrue);
+ expect(setUpInnerRun, isFalse);
+ });
+ });
+
+ test('top', () {
+ expect(setUpOuterRun, isFalse);
+ expect(setUpInnerRun, isFalse);
+ });
+ });
+
+}

Powered by Google App Engine
This is Rietveld 408576698