Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 13973018: PNaCl: Add ExpandByVal pass for expanding out by-value struct args and results (Closed)

Created:
7 years, 8 months ago by Mark Seaborn
Modified:
7 years, 8 months ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master
Visibility:
Public.

Description

PNaCl: Add ExpandByVal pass for expanding out by-value struct args and results This pass expands out the "byval" and "sret" argument attributes. This will affect the calling conventions for PPAPI under PNaCl (for passing PP_Var etc. by value), so the PNaCl PPAPI shims will need to be updated in order to enable this pass by default. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3400 TEST=PNaCl toolchain trybots + GCC torture tests + LLVM test suite + Spec2k Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=ac21bcb

Patch Set 1 #

Patch Set 2 : Fix tail calls #

Patch Set 3 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -0 lines) Patch
M include/llvm/InitializePasses.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M include/llvm/Transforms/NaCl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M lib/Transforms/NaCl/CMakeLists.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A lib/Transforms/NaCl/ExpandByVal.cpp View 1 2 1 chunk +191 lines, -0 lines 0 comments Download
A test/Transforms/NaCl/expand-byval.ll View 1 2 1 chunk +123 lines, -0 lines 0 comments Download
M tools/opt/opt.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Seaborn
7 years, 8 months ago (2013-04-23 01:09:49 UTC) #1
Derek Schuff
LGTM
7 years, 8 months ago (2013-04-23 22:47:05 UTC) #2
Mark Seaborn
7 years, 8 months ago (2013-04-24 00:03:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as rac21bcb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698