Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13973004: Convert string16 -> base::string16 in components/ (Closed)

Created:
7 years, 8 months ago by brettw
Modified:
7 years, 8 months ago
Reviewers:
Jói
CC:
chromium-reviews, Raman Kakilate, tfarina, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, sail+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman
Visibility:
Public.

Description

Convert string16 -> base::string16 in components/ BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193682

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1623 lines, -1553 lines) Patch
M components/autofill/browser/address.h View 2 chunks +11 lines, -11 lines 1 comment Download
M components/autofill/browser/address.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M components/autofill/browser/address_field.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/address_field.cc View 6 chunks +17 lines, -17 lines 0 comments Download
M components/autofill/browser/address_field_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/browser/address_unittest.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M components/autofill/browser/android/auxiliary_profile_loader_android.h View 1 chunk +15 lines, -13 lines 0 comments Download
M components/autofill/browser/android/auxiliary_profile_loader_android.cc View 4 chunks +17 lines, -16 lines 0 comments Download
M components/autofill/browser/android/auxiliary_profile_unittest_android.cc View 5 chunks +30 lines, -30 lines 0 comments Download
M components/autofill/browser/android/auxiliary_profiles_android.cc View 4 chunks +16 lines, -16 lines 0 comments Download
M components/autofill/browser/android/test_auxiliary_profile_loader_android.h View 1 chunk +39 lines, -39 lines 0 comments Download
M components/autofill/browser/android/test_auxiliary_profile_loader_android.cc View 1 chunk +29 lines, -26 lines 0 comments Download
M components/autofill/browser/autocheckout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autocheckout_manager.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/browser/autocomplete_history_manager.h View 3 chunks +11 lines, -10 lines 0 comments Download
M components/autofill/browser/autocomplete_history_manager.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M components/autofill/browser/autocomplete_history_manager_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/browser/autofill_country.h View 2 chunks +10 lines, -10 lines 0 comments Download
M components/autofill/browser/autofill_country.cc View 8 chunks +14 lines, -13 lines 0 comments Download
M components/autofill/browser/autofill_download_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/browser/autofill_external_delegate.h View 4 chunks +24 lines, -22 lines 0 comments Download
M components/autofill/browser/autofill_external_delegate.cc View 9 chunks +34 lines, -34 lines 0 comments Download
M components/autofill/browser/autofill_external_delegate_unittest.cc View 8 chunks +15 lines, -15 lines 0 comments Download
M components/autofill/browser/autofill_field.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/browser/autofill_field.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_field_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/browser/autofill_ie_toolbar_import_win.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M components/autofill/browser/autofill_manager.h View 3 chunks +15 lines, -13 lines 0 comments Download
M components/autofill/browser/autofill_manager.cc View 11 chunks +31 lines, -30 lines 0 comments Download
M components/autofill/browser/autofill_manager_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/autofill/browser/autofill_manager_unittest.cc View 41 chunks +191 lines, -179 lines 0 comments Download
M components/autofill/browser/autofill_merge_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/autofill/browser/autofill_metrics_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/browser/autofill_popup_delegate.h View 1 chunk +4 lines, -2 lines 0 comments Download
M components/autofill/browser/autofill_profile.h View 8 chunks +17 lines, -17 lines 0 comments Download
M components/autofill/browser/autofill_profile.cc View 27 chunks +73 lines, -66 lines 0 comments Download
M components/autofill/browser/autofill_profile_unittest.cc View 32 chunks +49 lines, -49 lines 0 comments Download
M components/autofill/browser/autofill_regexes.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/browser/autofill_regexes.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M components/autofill/browser/autofill_type.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/contact_info.h View 4 chunks +17 lines, -17 lines 0 comments Download
M components/autofill/browser/contact_info.cc View 6 chunks +22 lines, -20 lines 0 comments Download
M components/autofill/browser/contact_info_unittest.cc View 2 chunks +21 lines, -21 lines 0 comments Download
M components/autofill/browser/credit_card.h View 4 chunks +23 lines, -23 lines 0 comments Download
M components/autofill/browser/credit_card.cc View 20 chunks +54 lines, -53 lines 0 comments Download
M components/autofill/browser/credit_card_field.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/browser/credit_card_unittest.cc View 10 chunks +28 lines, -28 lines 0 comments Download
M components/autofill/browser/form_field.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/browser/form_field.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/browser/form_field_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M components/autofill/browser/form_group.h View 3 chunks +8 lines, -7 lines 0 comments Download
M components/autofill/browser/form_group.cc View 10 chunks +22 lines, -22 lines 0 comments Download
M components/autofill/browser/form_structure.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/form_structure.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/browser/form_structure_unittest.cc View 14 chunks +26 lines, -26 lines 0 comments Download
M components/autofill/browser/name_field_unittest.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M components/autofill/browser/password_autofill_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/browser/password_autofill_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/browser/password_autofill_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/browser/personal_data_manager.h View 2 chunks +8 lines, -8 lines 0 comments Download
M components/autofill/browser/personal_data_manager.cc View 10 chunks +23 lines, -21 lines 0 comments Download
M components/autofill/browser/personal_data_manager_mac.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M components/autofill/browser/personal_data_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/browser/phone_field.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/phone_field.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/browser/phone_number.h View 4 chunks +12 lines, -12 lines 0 comments Download
M components/autofill/browser/phone_number.cc View 9 chunks +19 lines, -18 lines 0 comments Download
M components/autofill/browser/phone_number_i18n.h View 4 chunks +23 lines, -23 lines 0 comments Download
M components/autofill/browser/phone_number_i18n.cc View 8 chunks +28 lines, -28 lines 0 comments Download
M components/autofill/browser/phone_number_i18n_unittest.cc View 12 chunks +69 lines, -67 lines 0 comments Download
M components/autofill/browser/phone_number_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M components/autofill/browser/test_autofill_external_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/browser/test_autofill_manager_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/autofill/browser/test_autofill_manager_delegate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/autofill/browser/validation.h View 1 chunk +8 lines, -8 lines 0 comments Download
M components/autofill/browser/validation.cc View 6 chunks +14 lines, -14 lines 0 comments Download
M components/autofill/browser/wallet/encryption_escrow_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/wallet/full_wallet.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/wallet/full_wallet.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/browser/wallet/instrument.h View 3 chunks +9 lines, -9 lines 0 comments Download
M components/autofill/browser/wallet/instrument.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/browser/wallet/instrument_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/browser/wallet/wallet_address.h View 4 chunks +34 lines, -31 lines 0 comments Download
M components/autofill/browser/wallet/wallet_items.h View 6 chunks +17 lines, -17 lines 0 comments Download
M components/autofill/browser/wallet/wallet_items.cc View 11 chunks +18 lines, -18 lines 0 comments Download
M components/autofill/browser/wallet/wallet_items_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/browser/wallet/wallet_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/common/autofill_messages.h View 5 chunks +13 lines, -13 lines 0 comments Download
M components/autofill/common/form_data.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/common/form_field_data.h View 2 chunks +5 lines, -5 lines 0 comments Download
M components/autofill/common/password_form_fill_data.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/renderer/autofill_agent.h View 4 chunks +11 lines, -11 lines 0 comments Download
M components/autofill/renderer/autofill_agent.cc View 11 chunks +57 lines, -53 lines 0 comments Download
M components/autofill/renderer/form_autofill_util.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/renderer/form_autofill_util.cc View 25 chunks +46 lines, -43 lines 0 comments Download
M components/autofill/renderer/form_cache.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/renderer/form_cache.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M components/autofill/renderer/password_autofill_agent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/renderer/password_autofill_agent.cc View 8 chunks +13 lines, -13 lines 0 comments Download
M components/autofill/renderer/password_generation_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/renderer/password_generation_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/user_prefs/pref_registry_syncable.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/visitedlink/test/visitedlink_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/webdata/autofill/autofill_entry.h View 1 chunk +5 lines, -5 lines 0 comments Download
M components/webdata/autofill/autofill_entry.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/webdata/autofill/autofill_table.h View 2 chunks +7 lines, -6 lines 0 comments Download
M components/webdata/autofill/autofill_table.cc View 19 chunks +31 lines, -29 lines 0 comments Download
M components/webdata/autofill/autofill_table_unittest.cc View 15 chunks +27 lines, -27 lines 0 comments Download
M components/webdata/autofill/autofill_webdata.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/webdata/autofill/autofill_webdata_service.h View 2 chunks +8 lines, -6 lines 0 comments Download
M components/webdata/autofill/autofill_webdata_service.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M components/webdata/autofill/web_data_service_unittest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M components/webdata/autofill/web_database_migration_unittest.cc View 15 chunks +23 lines, -23 lines 0 comments Download
M components/webdata/encryptor/encryptor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/webdata/encryptor/encryptor_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M components/webdata/encryptor/encryptor_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/webdata/encryptor/encryptor_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/webdata/encryptor/encryptor_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/zip/zip_internal.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
TBR=joi
7 years, 8 months ago (2013-04-11 17:39:09 UTC) #1
brettw
Committed patchset #2 manually as r193682.
7 years, 8 months ago (2013-04-11 17:54:41 UTC) #2
Jói
7 years, 8 months ago (2013-04-12 09:16:33 UTC) #3
Message was sent while issue was closed. 
LGTM with a nit I noticed.

https://codereview.chromium.org/13973004/diff/2001/components/autofill/browse...
File components/autofill/browser/address.h (right):

https://codereview.chromium.org/13973004/diff/2001/components/autofill/browse...
components/autofill/browser/address.h:30: const std::string& app_locale) const
OVERRIDE;
nit: indentation

Powered by Google App Engine
This is Rietveld 408576698