cc: Make discardable image metadata generation work with no caching.

cc: Make discardable image metadata generation work with no caching.

This patch ensures that we can generate discardable images metadata
whether we have picture caching enabled or we don't.

BUG=543208
R=pdr
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/1071919b3c990d7896b60ea2539a91196d7ebcce
Cr-Commit-Position: refs/heads/master@{#354124}

[vmpstr, 2015-10-14 20:16:11]

Please take a look.

[pdr., 2015-10-14 20:21:16]

Is the change description correct?

Should it say that this patch ensures we can _not_ generate discardable image
metadata when we use caching?

[vmpstr, 2015-10-14 20:24:10]

On 2015/10/14 20:21:16, pdr wrote:
> Is the change description correct?
> 
> Should it say that this patch ensures we can _not_ generate discardable image
> metadata when we use caching?

I think it's fine? We want to generate the metadata with caching (as we do now).
We also want to be able to generate it if we don't have caching, which currently
crashes

[pdr., 2015-10-14 20:25:51]

On 2015/10/14 at 20:24:10, vmpstr wrote:
> On 2015/10/14 20:21:16, pdr wrote:
> > Is the change description correct?
> > 
> > Should it say that this patch ensures we can _not_ generate discardable
image
> > metadata when we use caching?
> 
> I think it's fine? We want to generate the metadata with caching (as we do
now). We also want to be able to generate it if we don't have caching, which
currently crashes

Oh, face plam. Still learning how to read && statements. LGTM

[vmpstr, 2015-10-14 20:26:55]

On 2015/10/14 20:25:51, pdr wrote:
> On 2015/10/14 at 20:24:10, vmpstr wrote:
> > On 2015/10/14 20:21:16, pdr wrote:
> > > Is the change description correct?
> > > 
> > > Should it say that this patch ensures we can _not_ generate discardable
> image
> > > metadata when we use caching?
> > 
> > I think it's fine? We want to generate the metadata with caching (as we do
> now). We also want to be able to generate it if we don't have caching, which
> currently crashes
> 
> Oh, face plam. Still learning how to read && statements. LGTM

:) thanks!

[vmpstr, 2015-10-14 20:26:58]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2015-10-14 20:27:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397203003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397203003/1

[commit-bot: I haz the power, 2015-10-14 21:53:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-14 21:54:30]

Patchset 1 (id:??) landed as
https://crrev.com/1071919b3c990d7896b60ea2539a91196d7ebcce
Cr-Commit-Position: refs/heads/master@{#354124}