Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1397193005: mojo_run: support parallel Android runs of mojo_run. (Closed)

Created:
5 years, 2 months ago by ppi
Modified:
5 years, 2 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

mojo_run: support parallel Android runs of mojo_run. This patch adds a `--free-host-ports` flag to devtools that allows to run dev servers on system-allocated ports (so that we can have parallel runs) while still using fixed ports on the device (so that the caching still works). Running with `--free-host-ports` makes `adb_remote_setup` unable to work correctly, which is why this is being introduced behind a flag. Fixes #470. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/eec06de72752abcae761e709de28e9eebd3fa52a

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -26 lines) Patch
M mojo/devtools/common/devtoolslib/android_shell.py View 1 chunk +6 lines, -4 lines 0 comments Download
M mojo/devtools/common/devtoolslib/linux_shell.py View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell.py View 3 chunks +14 lines, -4 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell_arguments.py View 11 chunks +22 lines, -16 lines 2 comments Download
M mojo/devtools/common/devtoolslib/shell_config.py View 3 chunks +5 lines, -0 lines 0 comments Download
M mojo/devtools/common/docs/mojo_run.md View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ppi
Hi Ben, ptal.
5 years, 2 months ago (2015-10-13 21:55:37 UTC) #1
qsr
LGTM if the response to my question is no. https://codereview.chromium.org/1397193005/diff/1/mojo/devtools/common/devtoolslib/shell_arguments.py File mojo/devtools/common/devtoolslib/shell_arguments.py (left): https://codereview.chromium.org/1397193005/diff/1/mojo/devtools/common/devtoolslib/shell_arguments.py#oldcode105 mojo/devtools/common/devtoolslib/shell_arguments.py:105: ...
5 years, 2 months ago (2015-10-14 07:35:39 UTC) #2
ppi
https://codereview.chromium.org/1397193005/diff/1/mojo/devtools/common/devtoolslib/shell_arguments.py File mojo/devtools/common/devtoolslib/shell_arguments.py (left): https://codereview.chromium.org/1397193005/diff/1/mojo/devtools/common/devtoolslib/shell_arguments.py#oldcode105 mojo/devtools/common/devtoolslib/shell_arguments.py:105: def configure_local_origin(shell, local_dir, fixed_port=True): On 2015/10/14 07:35:39, qsr wrote: ...
5 years, 2 months ago (2015-10-14 16:53:20 UTC) #3
ppi
5 years, 2 months ago (2015-10-14 16:54:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eec06de72752abcae761e709de28e9eebd3fa52a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698