Issue 1397173004: Attempt to fix ThreadIterator_AddFindRemove flake

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1397173004: Attempt to fix ThreadIterator_AddFindRemove flake (Closed)

Created:
5 years, 2 months ago by Cutch

Modified:
5 years, 2 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Attempt to fix ThreadIterator_AddFindRemove flake - Add ThreadInList helper for tests. - Attempt 10 times with a 10 millisecond delay for the spawned thread to be removed from the list. - Simplify ThreadIteratorTestMain Committed: https://github.com/dart-lang/sdk/commit/4dff3efe945978185934ed4e04cec8015c9b180d

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -46 lines)			Patch
	M	runtime/vm/thread_test.cc	View	1	3 chunks	+25 lines, -46 lines	0 comments	Download

Total messages: 3 (1 generated)

Cutch

5 years, 2 months ago (2015-10-13 22:09:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
4dff3efe945978185934ed4e04cec8015c9b180d (presubmit successful).