[GN]: Enable PCH for WebKit on Mac.

[GN]: Enable PCH for WebKit on Mac.

+ Add a new WebKit-level config "mac_precompiled_headers".
+ Add it as a public_config on core:prerequisites since the targets that need it depend on core:prerequisites.
+ Add it as a normal config on :platform since only the target itself needs it, not any deps.

BUG=none

Committed: https://crrev.com/622249055279172f4b064ed2e0ace8aa0dadddc2
Cr-Commit-Position: refs/heads/master@{#353559}

[Bons, 2015-10-12 03:26:30]

andybons@chromium.org changed reviewers:
+ brettw@chromium.org, dpranke@chromium.org, mark@chromium.org,
thakis@chromium.org

[Bons, 2015-10-12 03:28:36]

The CQ bit was checked by andybons@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-12 03:28:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397143003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397143003/20001

[Bons, 2015-10-12 03:39:14]

https://codereview.chromium.org/1397143003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/BUILD.gn (right):

https://codereview.chromium.org/1397143003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/BUILD.gn:311:
"$bindings_core_v8_output_dir/V8InternalDictionary.h",
these changes are all due to gn format that had to be run in order for the
presubmit to pass. apologies for the noise.

[commit-bot: I haz the power, 2015-10-12 04:20:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-12 04:20:26]

Dry run: This issue passed the CQ dry run.

[brettw, 2015-10-12 16:47:27]

lgtm

https://codereview.chromium.org/1397143003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/BUILD.gn (right):

https://codereview.chromium.org/1397143003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/BUILD.gn:92: config("mac_prefix_header") {
It seems like this really turns on precompiled headers rather than just
inserting a prefix. It seems like the naming and the comment are misleading
here.

Also, if this is mac-only, can we wrap this definition in an is_mac condition?

[Bons, 2015-10-12 17:11:16]

https://codereview.chromium.org/1397143003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/BUILD.gn (right):

https://codereview.chromium.org/1397143003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/BUILD.gn:92: config("mac_prefix_header") {
On 2015/10/12 16:47:27, brettw wrote:
> It seems like this really turns on precompiled headers rather than just
> inserting a prefix. It seems like the naming and the comment are misleading
> here.
> 
> Also, if this is mac-only, can we wrap this definition in an is_mac condition?

Done.

[Nico, 2015-10-12 17:11:22]

lgtm 2

consider landing the `gn format` changes in a separate CL, so that the
behavior-preserving reformatting and the behavior change land separately

[Bons, 2015-10-12 17:11:51]

The CQ bit was checked by andybons@chromium.org

[Bons, 2015-10-12 17:11:51]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1397143003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-10-12 17:13:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397143003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397143003/60001

[commit-bot: I haz the power, 2015-10-12 18:16:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-12 18:16:51]

Patchset 4 (id:??) landed as
https://crrev.com/622249055279172f4b064ed2e0ace8aa0dadddc2
Cr-Commit-Position: refs/heads/master@{#353559}

[Nico, 2015-10-12 18:18:37]

"consider landing the `gn format` changes in a separate CL" ಠ_ಠ

[Bons, 2015-10-12 18:48:31]

Sorry. ¯\_(ツ)_/¯

On Mon, Oct 12, 2015 at 11:18 AM <thakis@chromium.org> wrote:

> "consider landing the `gn format` changes in a separate CL" ಠ_ಠ
>
> https://codereview.chromium.org/1397143003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Bons, 2015-10-12 18:48:32]

Sorry. ¯\_(ツ)_/¯

On Mon, Oct 12, 2015 at 11:18 AM <thakis@chromium.org> wrote:

> "consider landing the `gn format` changes in a separate CL" ಠ_ಠ
>
> https://codereview.chromium.org/1397143003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.