Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: src/preparser.cc

Issue 139713005: Follow-up to r19112. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/preparser.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/preparser.cc
diff --git a/src/preparser.cc b/src/preparser.cc
index 7d48dd8651757d6b0ce9d6436b1901918142e1ab..4150d33a7af0c2d998608db050d9faaa436b673b 100644
--- a/src/preparser.cc
+++ b/src/preparser.cc
@@ -1058,7 +1058,6 @@ PreParser::Expression PreParser::ParseMemberWithNewPrefixesExpression(
// is strict, we need to do an extra check.
if (result.IsStrictFunction() && !identifier.IsValidStrictVariable()) {
StrictModeIdentifierViolation(scanner()->location(),
- "strict_eval_arguments",
identifier,
ok);
return Expression::Default();
@@ -1496,8 +1495,7 @@ PreParser::Identifier PreParser::ParseIdentifier(
PreParser::Identifier name = GetIdentifierSymbol();
if (allow_eval_or_arguments == kDontAllowEvalOrArguments &&
!is_classic_mode() && name.IsEvalOrArguments()) {
- StrictModeIdentifierViolation(
- scanner()->location(), "strict_eval_arguments", name, ok);
+ StrictModeIdentifierViolation(scanner()->location(), name, ok);
}
return name;
} else if (is_classic_mode() &&
@@ -1546,10 +1544,9 @@ void PreParser::CheckDelayedStrictModeViolation(int beg_pos,
void PreParser::StrictModeIdentifierViolation(Scanner::Location location,
- const char* eval_args_type,
Identifier identifier,
bool* ok) {
- const char* type = eval_args_type;
+ const char* type = "strict_eval_arguments";
if (identifier.IsFutureReserved()) {
type = "unexpected_reserved";
} else if (identifier.IsFutureStrictReserved() || identifier.IsYield()) {
« no previous file with comments | « src/preparser.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698