Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 139713005: Follow-up to r19112. (Closed)

Created:
6 years, 10 months ago by marja
Modified:
6 years, 10 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Follow-up to r19112. There's only one error message for "eval" and "arguments", so no need to pass it to PreParser::StrictModeIdentifierViolation. BUG=3126 LOG=N R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19137

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M src/preparser.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/preparser.cc View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ulan
lgtm
6 years, 10 months ago (2014-02-06 09:38:28 UTC) #1
marja
6 years, 10 months ago (2014-02-06 10:16:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r19137 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698