Basic multi-module support

chrome/common/extensions/manifest.h

Index: chrome/common/extensions/manifest.h
diff --git a/chrome/common/extensions/manifest.h b/chrome/common/extensions/manifest.h
index c1887933ed1a582ca0b2b682f4920356f3598c20..7c3762894076196434c92200cc68739b2ee94570 100644
--- a/chrome/common/extensions/manifest.h
+++ b/chrome/common/extensions/manifest.h
@@ -55,7 +55,8 @@ class Manifest {
     // This is marked legacy because platform apps are preferred. For
     // backwards compatibility, we can't remove support for packaged apps
     TYPE_LEGACY_PACKAGED_APP,
-    TYPE_PLATFORM_APP
+    TYPE_PLATFORM_APP,
+    TYPE_SHARED_MODULE

[Matt Perry, 2013/04/25 20:16:31]

I'm wary of adding another extension type. What's wrong with shared modules
being a TYPE_EXTENSION with a special key? You can still use
SharedModuleInfo::IsSharedModule to do the same types of checks.

[elijahtaylor1, 2013/04/25 21:01:28]

It was suggested by erikkay and asargent originally.  I think it is mostly to
avoid running any code in the context of the shared module (background
pages/scripts aren't allowed for instance), as well as avoiding granting
permissions accidentally to the shared module in case the first case is broken.

[Matt Perry, 2013/04/25 21:07:23]

Does a new Type really buy you those things, though? You still have to special
case SHARED_MODULE types and have code that recognizes them. Whether that code
checks the extension type or uses something else to test IsSharedModule seems
irrelevant.

That said, thinking more about it, it does feel like this is separate from an
extension. (An app could depend on a shared module.) I was just worried that
this would lead to fragmentation in our code depending on the package type.

[elijahtaylor1, 2013/04/25 21:26:25]

I think so, right?  The keys listed in _manifest_features.json have most
features keyed to extension and apps types, very few things are keyed to "all",
and most of them seem appropriate for shared modules too.
Yeah, I don't necessarily like that aspect of it (as I had to fix a few switch
statements that didn't really relate just to fix compiler errors, I could see it
getting worse).

   };
 
   // Given two install sources, return the one which should take priority
@@ -122,6 +123,7 @@ class Manifest {
     return type_ == TYPE_LEGACY_PACKAGED_APP;
   }
   bool is_extension() const { return type_ == TYPE_EXTENSION; }
+  bool is_shared_module() const { return type_ == TYPE_SHARED_MODULE; }
 
   // These access the wrapped manifest value, returning false when the property
   // does not exist or if the manifest type can't access it.