chrome/common/extensions/manifest.cc - Issue 13971005: Basic multi-module support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest.cc

Issue 13971005: Basic multi-module support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add browser test Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/manifest.cc

diff --git a/chrome/common/extensions/manifest.cc b/chrome/common/extensions/manifest.cc

index 78ae18970dff321b9bac854b4ea2ae5ad1f0fcac..b57e16df0d328e6b24b1479d8d803edbbda22da2 100644

--- a/chrome/common/extensions/manifest.cc

+++ b/chrome/common/extensions/manifest.cc

@@ -106,6 +106,8 @@ Manifest::Manifest(Location location, scoped_ptr<base::DictionaryValue> value)

type_(TYPE_UNKNOWN) {

if (value_->HasKey(keys::kTheme)) {

type_ = TYPE_THEME;

+ } else if (value_->HasKey(keys::kExport)) {

+ type_ = TYPE_SHARED_MODULE;

} else if (value_->HasKey(keys::kApp)) {

if (value_->Get(keys::kWebURLs, NULL) ||

value_->Get(keys::kLaunchWebURL, NULL)) {