Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1682)

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

Issue 1397083003: Remove never_lint from WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: back to path Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
index 94e67dd841d38323afd7ef20022ac23056bb297f..8348baa56fc4be8a83f2ba67f62f1c058227fd62 100644
--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
@@ -4,6 +4,8 @@
package com.android.webview.chromium;
+import android.annotation.SuppressLint;
+import android.annotation.TargetApi;
import android.app.assist.AssistStructure.ViewNode;
import android.content.Context;
import android.content.res.Configuration;
@@ -196,6 +198,7 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate
@Override
// BUG=6790250 |javaScriptInterfaces| was only ever used by the obsolete DumpRenderTree
// so is ignored. TODO: remove it from WebViewProvider.
+ @TargetApi(Build.VERSION_CODES.LOLLIPOP)
public void init(final Map<String, Object> javaScriptInterfaces,
final boolean privateBrowsing) {
if (privateBrowsing) {
@@ -1712,6 +1715,7 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate
}
@Override
+ @SuppressLint("DrawAllocation")
public void onDraw(final Canvas canvas) {
mFactory.startYourEngines(true);
if (checkNeedsPost()) {
@@ -2008,6 +2012,7 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate
}
@Override
+ @SuppressLint("DrawAllocation")
public void onMeasure(final int widthMeasureSpec, final int heightMeasureSpec) {
mFactory.startYourEngines(false);
if (checkNeedsPost()) {

Powered by Google App Engine
This is Rietveld 408576698