Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2939)

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

Issue 1397083003: Remove never_lint from WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: suppress resouces Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
index 94e67dd841d38323afd7ef20022ac23056bb297f..e435f72c7cd86f701ced74c10871a1ab74e45d51 100644
--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
@@ -4,6 +4,7 @@
package com.android.webview.chromium;
+import android.annotation.SuppressLint;
import android.app.assist.AssistStructure.ViewNode;
import android.content.Context;
import android.content.res.Configuration;
@@ -77,6 +78,7 @@ import java.util.concurrent.TimeUnit;
* and a small set of no-op deprecated APIs.
*/
@SuppressWarnings("deprecation")
+@SuppressLint("NewApi")
newt (away) 2015/10/13 20:41:38 What NewApi warnings are you suppressing? NewApi i
michaelbai 2015/10/13 21:40:15 Done.
class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate,
WebViewProvider.ViewDelegate, SmartClipProvider {
private class WebViewChromiumRunQueue {
@@ -1712,6 +1714,7 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate
}
@Override
+ @SuppressLint("DrawAllocation")
public void onDraw(final Canvas canvas) {
mFactory.startYourEngines(true);
if (checkNeedsPost()) {
@@ -2008,6 +2011,7 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate
}
@Override
+ @SuppressLint("DrawAllocation")
public void onMeasure(final int widthMeasureSpec, final int heightMeasureSpec) {
mFactory.startYourEngines(false);
if (checkNeedsPost()) {

Powered by Google App Engine
This is Rietveld 408576698