build/android/lint/suppressions.xml - Issue 1397083003: Remove never_lint from WebView

Side by Side Diff: build/android/lint/suppressions.xml

Issue 1397083003: Remove never_lint from WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: suppress resouces Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« android_webview/glue/java/src/com/android/webview/chromium/WebViewDelegateFactory.java ('K') | « android_webview/glue/java/src/com/android/webview/chromium/WebViewDelegateFactory.java ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <lint>	2 <lint>

3 <!--	3 <!--

4 STOP! It looks like you want to suppress some lint errors:	4 STOP! It looks like you want to suppress some lint errors:

5 - Have you tried identifing the offending patch?	5 - Have you tried identifing the offending patch?

6 Ask the author for a fix and/or revert the patch.	6 Ask the author for a fix and/or revert the patch.

7 - It is preferred to add suppressions in the code instead of	7 - It is preferred to add suppressions in the code instead of

8 sweeping it under the rug here. See:	8 sweeping it under the rug here. See:

9	9

10 http://developer.android.com/tools/debugging/improving-w-lint.html	10 http://developer.android.com/tools/debugging/improving-w-lint.html

(...skipping 23 matching lines...) Expand all Loading...
34 <issue id="DrawAllocation">	34 <issue id="DrawAllocation">

35 <ignore path="content/public/android/java/src/org/chromium/content/browser/C ontentViewRenderView.java"/>	35 <ignore path="content/public/android/java/src/org/chromium/content/browser/C ontentViewRenderView.java"/>

36 <ignore path="content/public/android/java/src/org/chromium/content/browser/P opupZoomer.java"/>	36 <ignore path="content/public/android/java/src/org/chromium/content/browser/P opupZoomer.java"/>

37 </issue>	37 </issue>

38 <issue id="ExportedContentProvider">	38 <issue id="ExportedContentProvider">

39 <ignore path="AndroidManifest.xml"/>	39 <ignore path="AndroidManifest.xml"/>

40 </issue>	40 </issue>

41 <issue id="HandlerLeak">	41 <issue id="HandlerLeak">

42 <ignore path="remoting/android/java/src/org/chromium/chromoting/TapGestureDe tector.java"/>	42 <ignore path="remoting/android/java/src/org/chromium/chromoting/TapGestureDe tector.java"/>

43 </issue>	43 </issue>

	44 <issue id="IconMissingDensityFolder">

	45 <!-- see crbug.com/542435 -->

	46 <ignore path="android_webview/apk/java/res" />
	newt (away) 2015/10/13 20:41:38 Instead of suppressing density checks for the enti Instead of suppressing density checks for the entire folder, you can just suppress them for the individual file, using something like this <ignore regexp=".: icon_webview.png$"/> See line 58 for an example. michaelbai* 2015/10/13 21:40:15 Done. Show quoted text On 2015/10/13 20:41:38, newt wrote: > Instead of suppressing density checks for the entire folder, you can just > suppress them for the individual file, using something like this > > <ignore regexp=".*: icon_webview.png$"/> > > See line 58 for an example. Done.
	47 </issue>

44 <issue id="IconDensities">	48 <issue id="IconDensities">

45 <!-- crbug.com/457918 is tracking missing assets -->	49 <!-- crbug.com/457918 is tracking missing assets -->

46 <ignore path="components/web_contents_delegate_android/android/java/res/draw able-xxhdpi"/>	50 <ignore path="components/web_contents_delegate_android/android/java/res/draw able-xxhdpi"/>

47 <ignore path="components/web_contents_delegate_android/android/java/res/draw able-xxxhdpi"/>	51 <ignore path="components/web_contents_delegate_android/android/java/res/draw able-xxxhdpi"/>

48 <ignore path="content/public/android/java/res/drawable-xxhdpi"/>	52 <ignore path="content/public/android/java/res/drawable-xxhdpi"/>

49 <ignore path="content/public/android/java/res/drawable-xxxhdpi"/>	53 <ignore path="content/public/android/java/res/drawable-xxxhdpi"/>

50 <ignore path="chrome/android/java/res/drawable-xxhdpi"/>	54 <ignore path="chrome/android/java/res/drawable-xxhdpi"/>

51 <ignore path="chrome/android/java/res/drawable-xxxhdpi"/>	55 <ignore path="chrome/android/java/res/drawable-xxxhdpi"/>

52 <ignore path="ui/android/java/res/drawable-xxhdpi"/>	56 <ignore path="ui/android/java/res/drawable-xxhdpi"/>

53 <ignore path="ui/android/java/res/drawable-xxxhdpi"/>	57 <ignore path="ui/android/java/res/drawable-xxxhdpi"/>

(...skipping 47 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
101 <ignore path="content/shell/android/shell_apk/res/values/strings.xml" />	105 <ignore path="content/shell/android/shell_apk/res/values/strings.xml" />

102 </issue>	106 </issue>

103 <issue id="SignatureOrSystemPermissions" severity="ignore"/>	107 <issue id="SignatureOrSystemPermissions" severity="ignore"/>

104 <issue id="UnusedAttribute" severity="ignore"/>	108 <issue id="UnusedAttribute" severity="ignore"/>

105 <issue id="ViewConstructor" severity="ignore"/>	109 <issue id="ViewConstructor" severity="ignore"/>

106 <issue id="WrongCall" severity="ignore"/>	110 <issue id="WrongCall" severity="ignore"/>

107 <issue id="UselessParent">	111 <issue id="UselessParent">

108 <ignore path="chrome/android/java/res/layout/data_reduction_promo_screen.xml " />	112 <ignore path="chrome/android/java/res/layout/data_reduction_promo_screen.xml " />

109 </issue>	113 </issue>

110 </lint>	114 </lint>

OLD	NEW