third_party/WebKit/Source/core/frame/LocalFrame.cpp - Issue 1397073002: [Oilpan] Create UnsafePtr to store on-heap pointers in Vector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 1397073002: [Oilpan] Create UnsafePtr to store on-heap pointers in Vector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp ('k') | third_party/WebKit/Source/platform/heap/Handle.h » ('j') | third_party/WebKit/Source/platform/heap/Handle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

index c0b3b8d0f8d02582cc351d9b9eb321b87db82949..92dcda7402b93ffe3b01f8dbd2a010e38638b428 100644

--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

@@ -821,7 +821,7 @@ void LocalFrame::unregisterPluginElement(HTMLPlugInElement* plugin)

void LocalFrame::clearWeakMembers(Visitor* visitor)

{

- Vector<HTMLPlugInElement*> deadPlugins;

+ Vector<UnsafePtr<HTMLPlugInElement>> deadPlugins;

for (const auto& pluginElement : m_pluginElements) {

if (!Heap::isHeapObjectAlive(pluginElement)) {

pluginElement->shouldDisposePlugin();