Fix emission of move immediate for ARM integrated assembler.

Fix emission of move immediate for ARM integrated assembler.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4334
R=jpp@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=85342a763f5381892ae19933db7250b8d7447b8c

[Karl, 2015-10-12 20:37:02]

kschimpf@google.com changed reviewers:
+ jpp@chromium.org, stichnot@chromium.org

[John, 2015-10-12 20:45:27]

lgtm

https://chromiumcodereview.appspot.com/1397043003/diff/20001/src/IceAssembler...
File src/IceAssemblerARM32.h (right):

https://chromiumcodereview.appspot.com/1397043003/diff/20001/src/IceAssembler...
src/IceAssemblerARM32.h:242: // Converts from bool to bit.
optional: All of these helpers are part of the assembler's implementation. given
that they are static methods, I would just define them as free functions in
unnamed namespaces in the .cpp file. (same for the constexprs above.)

[Karl, 2015-10-12 21:24:56]

https://chromiumcodereview.appspot.com/1397043003/diff/20001/src/IceAssembler...
File src/IceAssemblerARM32.h (right):

https://chromiumcodereview.appspot.com/1397043003/diff/20001/src/IceAssembler...
src/IceAssemblerARM32.h:242: // Converts from bool to bit.
On 2015/10/12 20:45:27, John wrote:
> optional: All of these helpers are part of the assembler's implementation.
given
> that they are static methods, I would just define them as free functions in
> unnamed namespaces in the .cpp file. (same for the constexprs above.)

Done.

[John, 2015-10-12 21:30:53]

lgtm

[Karl, 2015-10-13 16:49:35]

Committed patchset #3 (id:40001) manually as
85342a763f5381892ae19933db7250b8d7447b8c (presubmit successful).