Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1835)

Unified Diff: pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart

Issue 1397043002: Introduce BackendImpact to separate enqueueing from data. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Remove Feature.NEW_SYMBOL Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart
diff --git a/pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart b/pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart
index 00394a59b95528fae6efa9a098633ac368922db0..e345a7c3b08426259622eca124ecb7ea1e061602 100644
--- a/pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart
+++ b/pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart
@@ -74,11 +74,7 @@ class CustomElementsAnalysis {
joinFor(enqueuer).instantiatedClasses.add(classElement);
}
- void registerTypeLiteral(DartType type, Registry registry) {
- assert(registry.isForResolution);
- // In codegen we see the TypeConstants instead.
- if (!registry.isForResolution) return;
sigurdm 2015/10/09 10:55:38 What??
Johnni Winther 2015/10/09 11:35:56 Yeah!
-
+ void registerTypeLiteral(DartType type) {
if (type.isInterfaceType) {
// TODO(sra): If we had a flow query from the type literal expression to
// the Type argument of the metadata lookup, we could tell if this type

Powered by Google App Engine
This is Rietveld 408576698