Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: test/unittests/compiler/common-operator-unittest.cc

Issue 1397003002: Fix another gcc 4.9.2 signed-compare error. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/common-operator-unittest.cc
diff --git a/test/unittests/compiler/common-operator-unittest.cc b/test/unittests/compiler/common-operator-unittest.cc
index bed100a6d8c2340edc461e411f758ba7f18c3116..67acfa82156277d812e6f4970c43adab3a232f05 100644
--- a/test/unittests/compiler/common-operator-unittest.cc
+++ b/test/unittests/compiler/common-operator-unittest.cc
@@ -194,9 +194,10 @@ TEST_F(CommonOperatorTest, Return) {
EXPECT_EQ(Operator::kNoThrow, op->properties());
EXPECT_EQ(input_count, op->ValueInputCount());
EXPECT_EQ(1, op->EffectInputCount());
- EXPECT_EQ(1, static_cast<uint32_t>(op->ControlInputCount()));
- EXPECT_EQ(2 + input_count, static_cast<uint32_t>(
- OperatorProperties::GetTotalInputCount(op)));
+ EXPECT_EQ(1u, static_cast<uint32_t>(op->ControlInputCount()));
bradn 2015/10/09 00:19:54 For this one you can just drop the cast.
paul.l... 2015/10/09 00:42:38 Done.
+ EXPECT_EQ(
+ 2u + input_count,
+ static_cast<uint32_t>(OperatorProperties::GetTotalInputCount(op)));
paul.l... 2015/10/09 00:42:37 I removed the cast here was well. input_count and
EXPECT_EQ(0, op->ValueOutputCount());
EXPECT_EQ(0, op->EffectOutputCount());
EXPECT_EQ(1, op->ControlOutputCount());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698