|
|
DescriptionFix another gcc 4.9.2 signed-compare error.
BUG=
Committed: https://crrev.com/9d66c8813aea9d573020dbf6bf28533d1183c490
Cr-Commit-Position: refs/heads/master@{#31199}
Patch Set 1 #
Total comments: 3
Patch Set 2 : remove casts #Messages
Total messages: 20 (7 generated)
paul.lind@imgtec.com changed reviewers: + bradnelson@google.com, machenbach@google.com, titzer@chromium.org
PTAL.
lgtm https://codereview.chromium.org/1397003002/diff/1/test/unittests/compiler/com... File test/unittests/compiler/common-operator-unittest.cc (right): https://codereview.chromium.org/1397003002/diff/1/test/unittests/compiler/com... test/unittests/compiler/common-operator-unittest.cc:197: EXPECT_EQ(1u, static_cast<uint32_t>(op->ControlInputCount())); For this one you can just drop the cast.
The CQ bit was checked by paul.lind@imgtec.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397003002/20001
Thanks Brad, I removed both casts, it seems fine, but please take another look. https://codereview.chromium.org/1397003002/diff/1/test/unittests/compiler/com... File test/unittests/compiler/common-operator-unittest.cc (right): https://codereview.chromium.org/1397003002/diff/1/test/unittests/compiler/com... test/unittests/compiler/common-operator-unittest.cc:197: EXPECT_EQ(1u, static_cast<uint32_t>(op->ControlInputCount())); On 2015/10/09 00:19:54, bradn wrote: > For this one you can just drop the cast. Done. https://codereview.chromium.org/1397003002/diff/1/test/unittests/compiler/com... test/unittests/compiler/common-operator-unittest.cc:200: static_cast<uint32_t>(OperatorProperties::GetTotalInputCount(op))); I removed the cast here was well. input_count and GetTotalInputCount() are both ints.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by bradnelson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397003002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6531)
On 2015/10/09 16:02:50, commit-bot: I haz the power wrote: > v8_presubmit on tryserver.v8 (JOB_FAILED, Michael, Ben, could one of you give the OK on this one?
machenbach@chromium.org changed reviewers: + machenbach@chromium.org
lgtm
The CQ bit was checked by bradnelson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397003002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9d66c8813aea9d573020dbf6bf28533d1183c490 Cr-Commit-Position: refs/heads/master@{#31199} |