Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1397003002: Fix another gcc 4.9.2 signed-compare error. (Closed)

Created:
5 years, 2 months ago by paul.l...
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix another gcc 4.9.2 signed-compare error. BUG= Committed: https://crrev.com/9d66c8813aea9d573020dbf6bf28533d1183c490 Cr-Commit-Position: refs/heads/master@{#31199}

Patch Set 1 #

Total comments: 3

Patch Set 2 : remove casts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M test/unittests/compiler/common-operator-unittest.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
paul.l...
PTAL.
5 years, 2 months ago (2015-10-09 00:12:10 UTC) #2
bradn
lgtm https://codereview.chromium.org/1397003002/diff/1/test/unittests/compiler/common-operator-unittest.cc File test/unittests/compiler/common-operator-unittest.cc (right): https://codereview.chromium.org/1397003002/diff/1/test/unittests/compiler/common-operator-unittest.cc#newcode197 test/unittests/compiler/common-operator-unittest.cc:197: EXPECT_EQ(1u, static_cast<uint32_t>(op->ControlInputCount())); For this one you can just ...
5 years, 2 months ago (2015-10-09 00:19:55 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397003002/20001
5 years, 2 months ago (2015-10-09 00:42:23 UTC) #5
paul.l...
Thanks Brad, I removed both casts, it seems fine, but please take another look. https://codereview.chromium.org/1397003002/diff/1/test/unittests/compiler/common-operator-unittest.cc ...
5 years, 2 months ago (2015-10-09 00:42:38 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-09 01:09:15 UTC) #8
bradn
lgtm
5 years, 2 months ago (2015-10-09 16:00:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397003002/20001
5 years, 2 months ago (2015-10-09 16:00:55 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6531)
5 years, 2 months ago (2015-10-09 16:02:50 UTC) #13
paul.l...
On 2015/10/09 16:02:50, commit-bot: I haz the power wrote: > v8_presubmit on tryserver.v8 (JOB_FAILED, Michael, ...
5 years, 2 months ago (2015-10-09 16:14:34 UTC) #14
Michael Achenbach
lgtm
5 years, 2 months ago (2015-10-09 18:49:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397003002/20001
5 years, 2 months ago (2015-10-09 20:02:25 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-09 20:04:02 UTC) #19
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 20:04:19 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9d66c8813aea9d573020dbf6bf28533d1183c490
Cr-Commit-Position: refs/heads/master@{#31199}

Powered by Google App Engine
This is Rietveld 408576698