Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1396993002: housecleaning: remove nonnullableTypes (Closed)

Created:
5 years, 2 months ago by Jennifer Messerly
Modified:
5 years, 2 months ago
Reviewers:
Leaf, vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

housecleaning: remove nonnullableTypes the non-nullable by default DEP seems a better way to go here R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/9e124ba8d47963eb378d757ed54d257617d63bee

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -253 lines) Patch
M lib/src/checker/checker.dart View 1 4 chunks +7 lines, -24 lines 0 comments Download
M lib/src/checker/rules.dart View 1 5 chunks +4 lines, -49 lines 1 comment Download
M lib/src/codegen/js_codegen.dart View 1 3 chunks +2 lines, -22 lines 0 comments Download
M lib/src/compiler.dart View 1 2 chunks +0 lines, -3 lines 0 comments Download
M lib/src/info.dart View 1 1 chunk +2 lines, -9 lines 0 comments Download
M lib/strong_mode.dart View 1 3 chunks +2 lines, -22 lines 0 comments Download
M test/checker/checker_test.dart View 1 chunk +0 lines, -97 lines 0 comments Download
M test/checker/inferred_type_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M test/testing.dart View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
5 years, 2 months ago (2015-10-08 22:55:18 UTC) #2
vsm
lgtm https://codereview.chromium.org/1396993002/diff/20001/lib/src/checker/rules.dart File lib/src/checker/rules.dart (left): https://codereview.chromium.org/1396993002/diff/20001/lib/src/checker/rules.dart#oldcode350 lib/src/checker/rules.dart:350: // The null type is a subtype of ...
5 years, 2 months ago (2015-10-09 15:29:38 UTC) #3
Jennifer Messerly
5 years, 2 months ago (2015-10-09 20:14:22 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
9e124ba8d47963eb378d757ed54d257617d63bee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698