Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: pkg/analysis_server/test/integration/asynchrony_test.dart

Issue 1396983004: Remove an unused test (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/integration/test_all.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/integration/asynchrony_test.dart
diff --git a/pkg/analysis_server/test/integration/asynchrony_test.dart b/pkg/analysis_server/test/integration/asynchrony_test.dart
deleted file mode 100644
index 4f3f5cffeda944a9e2831212d4423ea8794c5d59..0000000000000000000000000000000000000000
--- a/pkg/analysis_server/test/integration/asynchrony_test.dart
+++ /dev/null
@@ -1,79 +0,0 @@
-// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-library test.integration.analysis.error;
-
-import 'dart:async';
-
-import 'package:test_reflective_loader/test_reflective_loader.dart';
-import 'package:unittest/unittest.dart';
-
-import '../utils.dart';
-import 'integration_tests.dart';
-
-main() {
- initializeTestEnvironment();
-// defineReflectiveTests(AsynchronyIntegrationTest);
-}
-
-/**
- * Verify that the server's input and output streams are asynchronous by
- * attempting to flood its input buffer with commands without listening to
- * its output buffer for responses. The server should continue to train its
- * input buffer even though its output buffer is full.
- *
- * Once enough commands have been sent, we begin reading from the server's
- * output buffer, and verify that it responds to the last command.
- *
- * NB.
- *
- * This test was intentionally disabled, because after r43123 server
- * writes to stdout synchronously. So, now it is the client's responsibility
- * to read stdout in a timely manner to avoid blocking the server.
- */
-@reflectiveTest
-class AsynchronyIntegrationTest {
- /**
- * Number of messages to queue up before listening for responses.
- */
- static const MESSAGE_COUNT = 10000;
-
- /**
- * Connection to the analysis server.
- */
- final Server server = new Server();
-
- Future setUp() {
- return server.start();
- }
-
- test_asynchrony() {
- // Send MESSAGE_COUNT messages to the server without listening for
- // responses.
- Future lastMessageResult;
- for (int i = 0; i < MESSAGE_COUNT; i++) {
- lastMessageResult = server.send('server.getVersion', null);
- }
-
- // Flush the server's standard input stream to verify that it has really
- // received them all. If the server is blocked waiting for us to read
- // its responses, the flush will never complete.
- return server.flushCommands().then((_) {
- // Begin processing responses from the server.
- server.listenToOutput((String event, params) {
- // The only expected notification is server.connected.
- if (event != 'server.connected') {
- fail('Unexpected notification: $event');
- }
- });
-
- // Terminate the test when the response to the last message is received.
- return lastMessageResult.then((_) {
- server.send("server.shutdown", null).then((_) {
- return server.exitCode;
- });
- });
- });
- }
-}
« no previous file with comments | « no previous file | pkg/analysis_server/test/integration/test_all.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698