Issue 1396983003: Oilpan: fix build after r353261, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1396983003: Oilpan: fix build after r353261, part 2. (Closed)

Created:
5 years, 2 months ago by sof

Modified:
5 years, 2 months ago

Reviewers:
oilpan-reviews, haraken

CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Oilpan: fix build after r353261, part 2. HTMLAnchorElement needs to be a declared GC mixin. TBR=oilpan-reviews BUG=498219 NOTRY=true Committed: https://crrev.com/b4a8a4f9fa947a27f8c32cd8b079e15084dc4aeb Cr-Commit-Position: refs/heads/master@{#353275}

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	third_party/WebKit/Source/core/html/HTMLAnchorElement.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
	M	third_party/WebKit/Source/core/html/HTMLAreaElement.h	View		2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396983003/1

5 years, 2 months ago (2015-10-09 12:54:23 UTC) #3

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/b4a8a4f9fa947a27f8c32cd8b079e15084dc4aeb Cr-Commit-Position: refs/heads/master@{#353275}

5 years, 2 months ago (2015-10-09 12:59:38 UTC) #5

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages